Skip to content

Conversation

@anthonyshew
Copy link

@anthonyshew anthonyshew commented Jan 22, 2026

Summary

  • Follows Turborepo best practices for monorepo configuration
  • Fixes CI workflow that was using non-existent script name
  • Improves cache invalidation accuracy and parallel task execution

Changes

turbo.json

  • Changed globalDependencies from **/.env to .env - the wildcard was too broad and caused unnecessary cache invalidation
  • Added transit task pattern for lint and typecheck - enables parallel execution while maintaining correct cache invalidation when dependency source changes
  • Updated lint to use transit instead of ^lint (lint doesn't need built outputs from dependencies)
  • Added dependsOn: ["transit"] to typecheck for proper cross-package type dependency tracking

package.json (root)

  • Changed all turbo commands to use turbo run <task> instead of shorthand turbo <task> (recommended for scripts/CI)
  • Removed runtime dependencies block - these belonged in individual packages, not root
  • Removed unused dependencies: cheerio, unpdf, @types/cheerio

apps/app/package.json

  • Added @upstash/vector (was missing, code imports it)

.github/workflows/check-types.yml

  • Fixed script name from type-check:ci to typecheck:ci (matching actual script in package.json)

Testing

After merging, run bun install to update the lockfile, then verify:

  • bun run build works
  • bun run lint works
  • bun run typecheck works
  • CI passes

AI usage

- Use 'turbo run' instead of shorthand in package.json scripts
- Change globalDependencies from '**/.env' to '.env' for more specific caching
- Add transit task for parallel lint/typecheck with correct cache invalidation
- Fix CI workflow script name (type-check:ci -> typecheck:ci)
- Move runtime dependencies from root to individual packages
- Remove unused dependencies (cheerio, unpdf)
@vercel
Copy link

vercel bot commented Jan 22, 2026

@anthonyshew is attempting to deploy a commit to the Comp AI Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jan 22, 2026

CLA assistant check
All committers have signed the CLA.

@cursor
Copy link

cursor bot commented Jan 22, 2026

PR Summary

Optimizes monorepo task orchestration and CI reliability.

  • Turborepo config: narrows globalDependencies to .env; introduces transit task; updates lint and typecheck to depend on transit for correct cross-package invalidation
  • Root scripts: switches to turbo run variants for build, dev, lint, test, and typecheck; aligns typecheck:ci invocation
  • App deps: adds missing @upstash/vector in apps/app/package.json
  • CI: fixes workflow to run bun run typecheck:ci in .github/workflows/check-types.yml

Written by Cursor Bugbot for commit 7301322. This will update automatically on new commits. Configure here.

@anthonyshew
Copy link
Author

I'm unable to see if the changes to dependencies had a negative effect on builds, but the LLM's analysis in the chat transcript is believable. I reviewed where dependencies get used myself, and it seems those changes are correct, but I could have easily missed something.

@Marfuen
Copy link
Contributor

Marfuen commented Jan 22, 2026

@anthonyshew thanks for this, overall sounds like good changes, when you get a chance please fix the merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants