chore(build): drop unused Grunt/npm toolchain#141
Open
zackkatz wants to merge 3 commits into
Open
Conversation
bin/build-sass (PHP/scssphp via Composer) is the canonical SCSS-to-CSS compiler; the committed src/assets/trustedlogin.css is produced by it. The Grunt workflow added autoprefix-on-watch for local SCSS edits but was not on the release path. Removed Gruntfile.js, package.json, package-lock.json, yarn.lock, and .nvmrc. Also removed .github/workflows/tests.yml, which targeted the removed ubuntu-20.04 runner image and depended on the now-deleted package.json test:php script. PHPUnit jobs need to be re-added to .github/workflows/php-ci-tests.yml as a follow-up. Updated .gitattributes (drop export-ignore lines for files that no longer exist) and README.md (drop the npm run test:php bullet; document composer phpstan alongside composer test/lint/format).
Adds a Branching (Git Flow) section to AGENTS.md so contributors and agents target develop by default and route releases through release/* branches into main.
- Remote.php: drop dead `use WP_User;` and `use WP_Admin_Bar;` imports; drop unused `$key` from the errors-flatten foreach. - Client.php: unset() the unused exception binding from the WP_Debug_Data ImagickException catch (PHP 5.3 floor rules out catch-without-binding). - fake-saas/server.php: drop the unused `$state` arrow-fn param on the /__reset handler; PHP silently ignores extra args passed to closures with smaller arity, so with_state_locked()'s callsite is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bin/build-sass(PHP/scssphp) is the canonical SCSS-to-CSS compiler. The committedsrc/assets/trustedlogin.cssis produced by it. Grunt only added autoprefix-on-watch for local SCSS development and was not on the release path.package-lock.json/yarn.lock)..github/workflows/tests.yml, which targeted the retiredubuntu-20.04runner and depended on the deletedpackage.jsontest:phpscript.What's deleted
Gruntfile.jspackage.jsontest:phpwp-env shortcutpackage-lock.json/yarn.lock.nvmrc.github/workflows/tests.ymlubuntu-20.04; depended on deletedpackage.jsonWhat still works
bin/build-sasssmoke-tested locally; CSS output unchanged.composer lint(PHPCS) — clean.composer phpstan— clean.composer test(PHPUnit) — unchanged..github/workflows/php-ci-tests.yml(PHPCS + PHPStan) — unchanged..github/workflows/e2e.yml(Playwright) — unchanged; uses its owntests/e2e/package.jsonwhich is separate..gitattributesalready export-ignores any remaining dev cruft from the published archive.Follow-up needed
The deleted
tests.ymlwas the only workflow running PHPUnit in CI. PHPUnit should be added back into.github/workflows/php-ci-tests.yml(modernubuntu-latest, multiple PHP versions). Tracked separately.Test plan
composer install && composer lint && composer phpstan && composer testpass on a fresh clonebin/build-sass --namespace=foorecompilessrc/assets/trustedlogin.csswithout npm installedmaingo to zero after merge