Add reference-values-in.json file#11
Merged
Jakob-Naucke merged 3 commits intoAug 25, 2025
Merged
Conversation
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Merged
Contributor
Author
|
superseded by #12 (sorry Rhys for the noise -- the fate of an early adopter username) |
alicefr
reviewed
Aug 25, 2025
| if let serde_json::Value::String(hex) = value | ||
| && hex | ||
| .chars() | ||
| .all(|c| (c >= '0' && c <= '9') || (c >= 'a' && c <= 'f')) |
Contributor
There was a problem hiding this comment.
On Azure, iirc, the letter are capital, so maybe it is worth to reduce value to lowercase first
Contributor
Author
There was a problem hiding this comment.
compute-pcrs will also give lower case and this should be fixed attestation policy side. This is now included (cc @6-dehan)
Contributor
|
I added one comment but the rest looks good |
with dummy values that throw errors when not replaced with hex strings Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with dummy values that throw errors when not replaced with hex strings.
Also includes some nits.