combine: Multiple events per event ID#77
Open
bgartzi wants to merge 1 commit into
Open
Conversation
It was assumed that each TPMEventID would hold only 1 event at a time. Now that other PCR predictions and support for UKI are on the table, that does not happened to longer be true. This commit only updates internal plumbing. Pretty much the logic in tpmevents/combine so as to be able to process a list of TPMEvents per each kind of TPMEventID. It's now assumed that TPMEvents of a given TPMEventID move in block. In other words, that they can't be combined with TPMEvents from the other images independently. It's all TPMEvents of TPMEvent ID X from image A or from image B. It can't be TPMEvent 1 from image A and TPMEvent 2 from image B. Signed-off-by: Beñat Gartzia Arruabarrena <bgartzia@redhat.com>
Contributor
Author
|
@travier please, could you have a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was assumed that each TPMEventID would hold only 1 event at a time. Now that other PCR predictions and support for UKI are on the table, that does not happened to longer be true.
This commit only updates internal plumbing. Pretty much the logic in tpmevents/combine so as to be able to process a list of TPMEvents per each kind of TPMEventID.
It's now assumed that TPMEvents of a given TPMEventID move in block. In other words, that they can't be combined with TPMEvents from the other images independently. It's all TPMEvents of TPMEvent ID X from image A or from image B. It can't be TPMEvent 1 from image A and TPMEvent 2 from image B.
Fixes #76.
Affects: #33, #75