CTAP 2.3#54
Closed
0x0ece wants to merge 15 commits into
Closed
Conversation
8713128 to
0e5245f
Compare
…erableCredentials
Member
robin-nitrokey
left a comment
There was a problem hiding this comment.
First batch of comments. I’ve already prepared the suggested changes so you don’t have to do any changes yourself, just take a look at the comments and questions and let me know if you agree.
Member
robin-nitrokey
left a comment
There was a problem hiding this comment.
I have some more questions regarding the minPinLength implementation. We should definitely have some unit tests for this feature before merging it to make sure that all edge cases are handled correctly.
0x0ece
commented
May 22, 2026
2 tasks
12 tasks
Member
|
Closing in favor of #60. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #53, deps need to be modified
commit overview: