Skip to content

CTAP 2.3#54

Closed
0x0ece wants to merge 15 commits into
trussed-dev:mainfrom
0x0ece:0x0ece/ctap
Closed

CTAP 2.3#54
0x0ece wants to merge 15 commits into
trussed-dev:mainfrom
0x0ece:0x0ece/ctap

Conversation

@0x0ece
Copy link
Copy Markdown
Contributor

@0x0ece 0x0ece commented May 10, 2026

@0x0ece 0x0ece mentioned this pull request May 10, 2026
11 tasks
@0x0ece 0x0ece force-pushed the 0x0ece/ctap branch 4 times, most recently from 8713128 to 0e5245f Compare May 11, 2026 20:32
Copy link
Copy Markdown
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch of comments. I’ve already prepared the suggested changes so you don’t have to do any changes yourself, just take a look at the comments and questions and let me know if you agree.

Comment thread src/credential.rs
Comment thread src/lib.rs
Comment thread src/constants.rs
Comment thread src/ctap2.rs
Comment thread src/ctap2.rs
Comment thread src/state/migrate.rs
Comment thread src/state.rs
Comment thread src/state.rs
Copy link
Copy Markdown
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some more questions regarding the minPinLength implementation. We should definitely have some unit tests for this feature before merging it to make sure that all edge cases are handled correctly.

Comment thread src/state.rs
Comment thread src/state.rs
Comment thread src/ctap2.rs
Comment thread src/state.rs
Comment thread src/ctap2.rs
Comment thread src/state.rs
Comment thread src/state.rs
@robin-nitrokey robin-nitrokey mentioned this pull request May 22, 2026
2 tasks
Comment thread src/ctap2.rs
@robin-nitrokey
Copy link
Copy Markdown
Member

Closing in favor of #60.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants