Move benchmark from development to runtime dependency #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Ruby 3.5.0, benchmark will no longer be included in Ruby's default gems. Applications using httplog would encounter a LoadError unless they explicitly add benchmark to their own Gemfile, and there's a deprecation warning under 3.4.4. While benchmark is marked as a development dependency now, we're actually using it in several places to provide benchmark results when `config.log_benchmark = true` so it should be a runtime dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Ruby 3.5.0, benchmark will no longer be included in Ruby's
default gems. Applications using httplog would encounter a LoadError unless
they explicitly add benchmark to their own Gemfile, and there's a deprecation
warning under 3.4.4.
While benchmark is marked as a development dependency now, we're actually using
it in several places to provide benchmark results when
config.log_benchmark = trueso it should be a runtime dependency.