Review: zoom implementation and image correction.#532
Merged
Conversation
… keyboard shortcuts Cmd+[ and Cmd+].
Bug fixes - Fixes image shifting to coordinate 0,0 when applying zoom instead of staying centered. imageView now always occupies at least the visible scroll area size, allowing NSImageAlignCenter to center the image correctly. New behaviors - Image stays centered after every zoom change and when resizing the window. - Images that fit on screen open at 100% with the window sized to match. - Images larger than the screen are proportionally scaled on open. - The popup displays the exact percentage when scaling. If it does not match a fixed value, a temporary dynamic item is added and removed when another zoom level is selected. - Zoom In and Zoom Out navigate to the next/previous fixed value relative to the current percentage, even when the current zoom is a dynamic value. - Resizing the window proportionally rescales the image and updates the popup. - Minimum window size reduced from 200×200 to 100×100. - Maximum window size limited to the visible screen area (visibleFrame).
Owner
|
Excellent, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fixes
New behaviors