Skip to content

Comments

fix(minisatip): align Dockerfile with repo conventions#1458

Merged
Crow-Control merged 2 commits intorenovate/catalinii-minisatip-2.0.xfrom
copilot/sub-pr-1454
Feb 20, 2026
Merged

fix(minisatip): align Dockerfile with repo conventions#1458
Crow-Control merged 2 commits intorenovate/catalinii-minisatip-2.0.xfrom
copilot/sub-pr-1454

Conversation

Copy link
Contributor

Copilot AI commented Feb 20, 2026

The Renovate-generated minisatip Dockerfile deviated from established repo conventions in several ways.

Changes

  • Base image tag: ubuntu:24.4ubuntu:24.4.0 (matches every other app using this base)
  • COPY permissions: COPY ./ /COPY --chmod=0775 . /
  • Working directory: Added WORKDIR /config at end of Dockerfile
  • ENV indentation: Normalized to consistent 4-space indent

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: Crow-Control <7613738+Crow-Control@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix dependency update for catalinii/minisatip to v2.0.72 fix(minisatip): align Dockerfile with repo conventions Feb 20, 2026
Copilot AI requested a review from Crow-Control February 20, 2026 12:56
@Crow-Control Crow-Control marked this pull request as ready for review February 20, 2026 12:59
Copilot AI review requested due to automatic review settings February 20, 2026 12:59
@Crow-Control Crow-Control merged commit 4259ab8 into renovate/catalinii-minisatip-2.0.x Feb 20, 2026
2 checks passed
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the minisatip container Dockerfile with this repository’s standard Ubuntu base image tagging and runtime/layout conventions, improving consistency with other app images built from ghcr.io/trueforge-org/ubuntu.

Changes:

  • Update base image tag from 24.4 to 24.4.0 (digest unchanged).
  • Normalize ENV formatting and set file permissions on copied root files via COPY --chmod=0775.
  • Set WORKDIR /config so the default working directory matches the expected persistent config location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants