fix(windows): repair MSVC build after new async API additions#28
Merged
Conversation
- config.w32: add missing sources async_plain_event.c, http3_static_response.c, http_compression_pool.c (present in config.m4 but absent from the Windows build list, causing LNK2019) - tls_layer.c: move #ifdef SSL_MODE_RELEASE_BUFFERS out of SSL_CTX_set_mode() argument list — /Zc:preprocessor rejects preprocessor directives inside macro invocations - scripts/run-tests-windows.bat: fix extension name (php_true_async_server.dll) and add EXT_BUILD var so the INI points at the correct DLL location; always regenerate the INI
Contributor
CoverageTotal lines: 77.39% → 77.41% (+0.02 pp)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async_plain_event.c,http3_static_response.c,http_compression_pool.c— они есть вconfig.m4но отсутствовали в Windows-сборке, что приводило к LNK2019 при линковке#ifdef SSL_MODE_RELEASE_BUFFERSвынесен за пределы аргументовSSL_CTX_set_mode()—/Zc:preprocessor(conforming preprocessor) запрещает директивы препроцессора внутри вызовов макросовphp_true_async_server.dll), добавлена переменнаяEXT_BUILDуказывающая на директорию с DLL расширения, INI теперь всегда пересоздаётсяTest plan
phpsdk-vs17-x64.bat+_local_build.batпроходит без ошибокtest_compression_negotiate,test_multipart_parser,test_multipart_processor,test_win32_compat)