Skip to content

feat(actuator): prevent duplicate registration and stabilize CI#6447

Open
halibobo1205 wants to merge 1 commit intotronprotocol:developfrom
halibobo1205:feat/register_actuator_opt
Open

feat(actuator): prevent duplicate registration and stabilize CI#6447
halibobo1205 wants to merge 1 commit intotronprotocol:developfrom
halibobo1205:feat/register_actuator_opt

Conversation

@halibobo1205
Copy link
Copy Markdown
Contributor

@halibobo1205 halibobo1205 commented Sep 10, 2025

What does this PR do?

  • Add a registration status check to prevent duplicate initialization during CI test runs.
  • Throw TronError on actuator instantiation failures to improve error visibility and debugging.
  • Narrow package scanning from "org.tron" to "org.tron.core.actuator" to reduce reflection overhead and speed up registration.
  • Remove JVM args for CI test to avoid JDK8 G1 GC bugs and Evacuation Pause failures.
  • Optimize console output to prevent test OOM
  • Adjust memory and parallelism settings
  • exclude dnsjava InetAddressResolverProvider: see HADOOP-19288

Why are these changes required?
Optimize TransactionRegister to prevent duplicate CI registrations.

first init

Before: Reflections took 375 ms to scan 11 urls, producing 525 keys and 3121 values
After:  Reflections took 188 ms to scan 3 urls, producing 4 keys and 78 values 

repeat init

Before: Reflections took 165 ms to scan 11 urls, producing 525 keys and 3121 values
After:  Reflections took 24 ms to scan 3 urls, producing 4 keys and 78 values

This PR has been tested by:

  • Unit Tests
  • Manual Testing

Follow up

Extra details

@halibobo1205 halibobo1205 force-pushed the feat/register_actuator_opt branch 3 times, most recently from d8f43fb to 5a9d816 Compare September 11, 2025 09:39
@halibobo1205 halibobo1205 changed the title refactor(TransactionRegister): enhance actuator registration feat(TransactionRegister): prevent duplicate registration and stabilize CI Sep 11, 2025
@halibobo1205 halibobo1205 force-pushed the feat/register_actuator_opt branch 3 times, most recently from ad89386 to 0fbdf52 Compare September 30, 2025 03:50
@halibobo1205 halibobo1205 changed the base branch from release_v4.8.1 to develop February 27, 2026 03:17
@halibobo1205 halibobo1205 force-pushed the feat/register_actuator_opt branch 3 times, most recently from 6e93db9 to 28b4d6d Compare February 27, 2026 06:46
@halibobo1205 halibobo1205 changed the title feat(TransactionRegister): prevent duplicate registration and stabilize CI feat(TransactionRegister): prevent duplicate registration Feb 27, 2026
@halibobo1205 halibobo1205 force-pushed the feat/register_actuator_opt branch from 28b4d6d to dcb8fd9 Compare February 27, 2026 06:49
@halibobo1205 halibobo1205 changed the title feat(TransactionRegister): prevent duplicate registration feat(Transaction): prevent duplicate registration and stabilize CI Feb 27, 2026
@halibobo1205 halibobo1205 force-pushed the feat/register_actuator_opt branch from dcb8fd9 to 636e991 Compare March 2, 2026 11:29
@halibobo1205 halibobo1205 changed the title feat(Transaction): prevent duplicate registration and stabilize CI feat(actuator): prevent duplicate registration and stabilize CI Mar 2, 2026
@halibobo1205 halibobo1205 force-pushed the feat/register_actuator_opt branch 2 times, most recently from 453b4cd to 5fb8181 Compare March 3, 2026 02:12
@halibobo1205 halibobo1205 force-pushed the feat/register_actuator_opt branch from 5fb8181 to be4241e Compare March 10, 2026 07:35
@lvs0075
Copy link
Copy Markdown
Collaborator

lvs0075 commented Mar 30, 2026

This feature has been included in the discussions for version 4.8.2:#6585 (comment)

Changes:
- Add a registration status check to prevent duplicate initialization during CI test runs.
- Throw TronError on actuator instantiation failures to improve error visibility and debugging.
- Narrow package scanning from "org.tron" to "org.tron.core.actuator" to reduce reflection overhead and speed up registration.
- Remove JVM args for CI test to avoid JDK8 G1 GC bugs and Evacuation Pause failures.
- Optimize console output to prevent test OOM for CI
- Adjust memory and parallelism settings
- Exclude dnsjava InetAddressResolverProvider
@halibobo1205 halibobo1205 force-pushed the feat/register_actuator_opt branch from be4241e to 18b5e61 Compare March 31, 2026 03:25
@Sunny6889 Sunny6889 moved this to In Review in java-tron Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

7 participants