Add tests and implement additional CFL conditions for multiphase #1024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svchb
added
enhancement
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1024 +/- ##
==========================================
+ Coverage 65.70% 66.18% +0.47%
==========================================
Files 121 123 +2
Lines 8797 8847 +50
==========================================
+ Hits 5780 5855 +75
+ Misses 3017 2992 -25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
svchb
changed the title
efaulhaber
requested changes
Jan 7, 2026
Comment on lines
480
to
492
| dt_interfaces = Inf | ||
| nsystems = length(systems) | ||
| if nsystems > 1 | ||
| for i in 1:(nsystems - 1) | ||
| system = systems[i] | ||
| for j in (i + 1):nsystems | ||
| neighbor_system = systems[j] | ||
| dt_interfaces = min(dt_interfaces, | ||
| calculate_interface_dt(v_ode, u_ode, cfl_number, | ||
| system, neighbor_system, semi)) | ||
| end | ||
| end | ||
| end |
Member
There was a problem hiding this comment.
Why is this happening in every simulation now, even if no multiphase is used? There must be a better way to add this specifically in simulations where it's required, which are currently the minority. Maybe as a kwarg to the callback?
Collaborator
Author
There was a problem hiding this comment.
I narrowed the condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.