Skip to content

Conversation

@devintrivir
Copy link

New progress bars will not overwrite each other nor the console outputs. New spinners, loading bars, and handling stdout and stderr messages,

Copy link
Collaborator

@phalestrivir phalestrivir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but there are two things that need to be done still:

  1. Run npm run lint:fix to fix the linting issues
  2. Some of the tests are now failing due to the new progress indicators, namely anything related to snapshots which are snapshotting the output. I believe the problem is that before the progress indicators used to be considered "error" output, but now they are "standard" output. I think having them be "standard" output makes sense (I'm not actually sure what the reason is why they were originally error output, this may be something we want to confirm with Huston/Volker), but we'll need to update the snapshots accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants