Add frodo config-manager export terms-and-conditions command #27
Conversation
config-manager theme export feature added config-manager services export feature WIP config-manager scripts export feature added config-manager mappings export feature added
added service provider export command
devintrivir
force-pushed
the
feature/config-manager-terms
branch
from
e3de0a9 to
878126e
Compare
phalestrivir
left a comment
phalestrivir
left a comment
There was a problem hiding this comment.
You will want to add tests for the new commands. You will need one e2e test, and you will need a few client_cli tests.
| import { printMessage, verboseMessage } from '../../utils/Console'; | ||
| import { FrodoCommand } from '../FrodoCommand'; | ||
|
|
||
| const deploymentTypes = ['cloud', 'forgeops']; |
There was a problem hiding this comment.
Do we know if fr config manager can work with ForgeOps? I don't think it does because service accounts don't exist in ForgeOps deployments and I don't see anything indicating ForgeOps is supported in their documentation.
If ForgeOps isn't supported, this should just include 'cloud' and no other deployment types.
| import { extractFrConfigDataToFile } from '../utils/Config'; | ||
| const { | ||
| exportTermsAndConditions, | ||
| } = frodo.terms; |
There was a problem hiding this comment.
You will want to use this instead:
const { readConfigEntity } = frodo.idm;
I think that's the import for it. You can read the terms and conditions directly this way without needing your own custom implementation (see my review for the Frodo-Lib PR). The entity id you would pass into it would be selfservice.terms
| */ | ||
| export async function exportTermsAndConditionsToFiles(): Promise<boolean> { | ||
| try { | ||
| const exportData = await exportTermsAndConditions(); |
There was a problem hiding this comment.
See previous comment, this should be const exportData = await readConfigEntity('selfservice.terms');
skootrivir
force-pushed
the
feature/config-manager-terms
branch
from
36e4d4e to
fe227fa
Compare
skootrivir
force-pushed
the
config-manager
branch
from
15fa910 to
8fe70e9
Compare
|
Everything in this PR should be in this one: #34 |
No description provided.