fix(workers): prevent ERR_IPC_CHANNEL_CLOSED errors from causing an unhandled exception on TaskRunProcess

[ericallam]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 9c91d65

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 26 packages

Name	Type
@trigger.dev/core	Patch
@trigger.dev/build	Patch
trigger.dev	Patch
@trigger.dev/python	Patch
@trigger.dev/redis-worker	Patch
@trigger.dev/schema-to-json	Patch
@trigger.dev/sdk	Patch
@internal/cache	Patch
@internal/clickhouse	Patch
@internal/redis	Patch
@internal/replication	Patch
@internal/run-engine	Patch
@internal/schedule-engine	Patch
@internal/testcontainers	Patch
@internal/tracing	Patch
@internal/zod-worker	Patch
d3-chat	Patch
references-d3-openai-agents	Patch
references-nextjs-realtime	Patch
references-realtime-hooks-test	Patch
references-realtime-streams	Patch
references-telemetry	Patch
@trigger.dev/react-hooks	Patch
@trigger.dev/rsc	Patch
@trigger.dev/database	Patch
@trigger.dev/otlp-importer	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[coderabbitai]

Walkthrough

This pull request addresses ERR_IPC_CHANNEL_CLOSED errors in the task run process by adding error event handling to a child process. A changeset file documents the patch release for @trigger.dev/core. The implementation adds a new error event listener to the child process and introduces a private error handler method that logs debug information including the error and process ID. No changes to exported or public declarations are made.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify error handler scope: Confirm that the error event handler properly intercepts and prevents ERR_IPC_CHANNEL_CLOSED from propagating as an unhandled exception without suppressing other critical errors
• Process lifecycle impact: Ensure that adding the error handler doesn't interfere with existing exit handling or normal message flow in the task run process
• Logging sufficiency: Assess whether the debug-level logging is appropriate for this error or if additional recovery/retry logic is needed

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Description check	⚠️ Warning	No pull request description was provided by the author; the description is entirely empty and missing all required template sections.	Add a complete PR description following the repository template, including issue reference, testing steps, changelog entry, and any relevant screenshots.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and specifically describes the main change: fixing ERR_IPC_CHANNEL_CLOSED errors in TaskRunProcess to prevent unhandled exceptions.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch ea-branch-104

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 748ae65 and 9c91d65.

📒 Files selected for processing (2)

• .changeset/lovely-coats-draw.md (1 hunks)
• packages/cli-v3/src/executions/taskRunProcess.ts (2 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

**/*.{ts,tsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.{ts,tsx}: Use types over interfaces for TypeScript
Avoid using enums; prefer string unions or const objects instead

Files:

• packages/cli-v3/src/executions/taskRunProcess.ts

**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

Use function declarations instead of default exports

Files:

• packages/cli-v3/src/executions/taskRunProcess.ts

**/*.{js,ts,jsx,tsx,json,md,css,scss}

📄 CodeRabbit inference engine (AGENTS.md)

Format code using Prettier

Files:

• packages/cli-v3/src/executions/taskRunProcess.ts

🧠 Learnings (4)

📓 Common learnings

Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger/**/*.{ts,tsx,js,jsx} : Use `.withStreams()` to subscribe to realtime streams from task metadata in addition to run changes

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 2593
File: packages/core/src/v3/workers/warmStartClient.ts:168-170
Timestamp: 2025-10-08T11:48:12.327Z
Learning: The trigger.dev runners execute only in Node 21 and 22 environments, so modern Node.js APIs like AbortSignal.any (introduced in v20.3.0) are supported.

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 1418
File: packages/core/src/v3/errors.ts:364-371
Timestamp: 2024-10-18T15:41:52.352Z
Learning: In `packages/core/src/v3/errors.ts`, within the `taskRunErrorEnhancer` function, `error.message` is always defined, so it's safe to directly call `error.message.includes("SIGTERM")` without additional checks.

📚 Learning: 2025-10-08T11:48:12.327Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 2593
File: packages/core/src/v3/workers/warmStartClient.ts:168-170
Timestamp: 2025-10-08T11:48:12.327Z
Learning: The trigger.dev runners execute only in Node 21 and 22 environments, so modern Node.js APIs like AbortSignal.any (introduced in v20.3.0) are supported.

Applied to files:

• .changeset/lovely-coats-draw.md

📚 Learning: 2024-10-07T10:32:30.100Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 1387
File: packages/cli-v3/src/executions/taskRunProcess.ts:408-413
Timestamp: 2024-10-07T10:32:30.100Z
Learning: In the `parseExecuteError` method in `packages/cli-v3/src/executions/taskRunProcess.ts`, using `String(error)` to populate the `message` field works fine and even prepends `error.name`.

Applied to files:

• packages/cli-v3/src/executions/taskRunProcess.ts

📚 Learning: 2024-10-18T15:41:52.352Z

Learnt from: nicktrn
Repo: triggerdotdev/trigger.dev PR: 1418
File: packages/core/src/v3/errors.ts:364-371
Timestamp: 2024-10-18T15:41:52.352Z
Learning: In `packages/core/src/v3/errors.ts`, within the `taskRunErrorEnhancer` function, `error.message` is always defined, so it's safe to directly call `error.message.includes("SIGTERM")` without additional checks.

Applied to files:

• packages/cli-v3/src/executions/taskRunProcess.ts

🧬 Code graph analysis (1)

packages/cli-v3/src/executions/taskRunProcess.ts (3)

apps/kubernetes-provider/src/taskMonitor.ts (1)

• error (85-91)

packages/core/src/v3/tracer.ts (1)

• logger (56-64)

packages/cli-v3/src/utilities/logger.ts (1)

• logger (113-113)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (23)

• GitHub Check: units / internal / 🧪 Unit Tests: Internal (8, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (5, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (6, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (7, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (7, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (3, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (2, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (8, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (4, 8)
• GitHub Check: units / internal / 🧪 Unit Tests: Internal (1, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (5, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (6, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (3, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (4, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (2, 8)
• GitHub Check: units / webapp / 🧪 Unit Tests: Webapp (1, 8)
• GitHub Check: units / packages / 🧪 Unit Tests: Packages (1, 1)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (ubuntu-latest - npm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - pnpm)
• GitHub Check: e2e / 🧪 CLI v3 tests (windows-latest - npm)
• GitHub Check: typecheck / typecheck
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (2)

packages/cli-v3/src/executions/taskRunProcess.ts (1)

235-238: Child process error handler correctly prevents unhandled exceptions; confirm behavior for non‑exit errors

Wiring this._child.on("error", this.#handleError.bind(this)) and handling it with a lightweight debug logger is a good, minimal way to stop ERR_IPC_CHANNEL_CLOSED from taking down the process via an unhandled 'error' event.

One thing to sanity‑check: all the cleanup and promise rejection logic lives in #handleExit, and #handleError intentionally just logs. For the IPC‑channel‑closed case that motivated this PR, you should still get a subsequent "exit" and thus proper rejection of pending attempts. If there are any ChildProcess error paths in your environment (e.g. spawn failures) that emit 'error' without a matching 'exit', those executions could now hang instead of crashing the process.

If that’s a realistic scenario here, consider either:

• Marking the process unhealthy in #handleError (e.g. flipping a flag that upstream callers already check), or
• Special‑casing non‑ERR_IPC_CHANNEL_CLOSED errors in #handleError to fail fast / surface a clearer error upstream.

Also applies to: 325-327

.changeset/lovely-coats-draw.md (1)

1-5: Changeset scope and description look appropriate

Patch bump for @trigger.dev/core and the description clearly match the TaskRunProcess fix; nothing to change here.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}