Collect logs context switch #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johan1252
reviewed
Oct 20, 2022
johan1252
reviewed
Oct 20, 2022
Co-authored-by: Johan Cornelissen <johan1252@gmail.com>
Co-authored-by: Johan Cornelissen <johan1252@gmail.com>
Hounddog
commented
Oct 21, 2022
Author
|
Thank you for the Review. I have seen that i missed removing the resultdir flag and the corefile pattern. |
raphabot
reviewed
Oct 21, 2022
Contributor
|
Hi @Hounddog, thanks for contributing. Can you elaborate more about your use case where you can't use environment variables to specify release and namespace? |
Author
|
I have no reason for this. My only concern here is that smartcheck has a similar script and uses parameters instead of environment variables. I personally also feel that i am more flexible with parameters to change them as required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is required for us to set the context in the logs to select which cluster should be used.
I have removed the need to use Environment variables and instead provide parameters. (Similar to smartcheck implementation)
I have implemented a context switch to switch between prod and staging Kubernetes cluster.
The Readme has been updated to Reflect the changes.
I was able to use this locally to provide logs to your support team.