Android: revert "Add postfix for Debug configuration"#5
Closed
Coeur wants to merge 1 commit intotransmission:masterfrom
Closed
Android: revert "Add postfix for Debug configuration"#5Coeur wants to merge 1 commit intotransmission:masterfrom
Coeur wants to merge 1 commit intotransmission:masterfrom
Conversation
|
@Coeur: Why it is needed to revert it? |
Author
|
Details in libevent#1817 And as the PR title says, that is to fix the build for Android. |
Member
|
Same answer as #6 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, Transmission's fork of libevent needs a
post-2.2.0-transmissionbranch:https://github.com/transmission/libevent/branches/all
Once created, we can retarget this PR to the new 2.2 branch.
Then, regarding the scope of this PR, it's the same as libevent#1817 and is needed for Transmission to migrate from libevent 2.1 to libevent 2.2 (transmission/transmission#7765).