Skip to content
This repository was archived by the owner on Mar 27, 2026. It is now read-only.

autofixes from prettier and eslint --write#425

Closed
bencmbrook wants to merge 8 commits intobencmbrook/upgrade-pretter-eslint-nodefrom
bencmbrook/eslintfixes
Closed

autofixes from prettier and eslint --write#425
bencmbrook wants to merge 8 commits intobencmbrook/upgrade-pretter-eslint-nodefrom
bencmbrook/eslintfixes

Conversation

@bencmbrook
Copy link
Copy Markdown
Member

@bencmbrook bencmbrook commented Jul 17, 2025

PR stack:

main
<--#427 (eslint and prettier config changes)
<--#425 (auto-formatting from config changes)
<--#426 (manual fixes which actually are code changes)

Related Issues

  • [none]

Security Implications

[none]

System Availability

[none]

@bencmbrook bencmbrook changed the title bencmbrook/eslintfixes autofixes from prettier and eslint --write Jul 17, 2025
@bencmbrook bencmbrook mentioned this pull request Jul 17, 2025
export function extractClientError(err: string): string | null {
return CLIENT_ERROR.test(err) ? CLIENT_ERROR.exec(err)![1] : null;
export function extractClientError(error: string): string | null {
return CLIENT_ERROR.test(error) ? CLIENT_ERROR.exec(error)![1] : null;

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings starting with '{\"message\":\"' and with many repetitions of '{\"message\":\"a'.
export function extractClientError(err: string): string | null {
return CLIENT_ERROR.test(err) ? CLIENT_ERROR.exec(err)![1] : null;
export function extractClientError(error: string): string | null {
return CLIENT_ERROR.test(error) ? CLIENT_ERROR.exec(error)![1] : null;

Check failure

Code scanning / CodeQL

Polynomial regular expression used on uncontrolled data High

This
regular expression
that depends on
library input
may run slow on strings starting with '{\"message\":\"' and with many repetitions of '{\"message\":\"a'.
[key.replace(/[^a-z_.+\-A-Z -~]/g, '')]: value,
(accumulator, [key, value]) =>
Object.assign(accumulator, {
[key.replaceAll(/[^a-z_.+\-A-Z -~]/g, '')]: value,

Check warning

Code scanning / CodeQL

Overly permissive regular expression range Medium

Suspicious character range that overlaps with A-Z in the same character class, and overlaps with a-z in the same character class.
@bencmbrook bencmbrook changed the base branch from main to bencmbrook/upgrade-pretter-eslint-node July 22, 2025 21:42
@bencmbrook bencmbrook closed this Mar 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants