Skip to content

Fix Python wrapper doc namespace rendering#591

Open
MukundaKatta wants to merge 1 commit into
trailofbits:mainfrom
MukundaKatta:codex/fix-python-wrapper-doc-names
Open

Fix Python wrapper doc namespace rendering#591
MukundaKatta wants to merge 1 commit into
trailofbits:mainfrom
MukundaKatta:codex/fix-python-wrapper-doc-names

Conversation

@MukundaKatta
Copy link
Copy Markdown

Closes #500

Summary

  • remove the extra namespace separator from the Python wrapper class doc template
  • update checked-in generated wrapper docs from mx::::Type to mx::Type

Verification

  • rg -n "mx::::|Wrapper for \{cxx_namespace\}::\{cxx_class_name\}" bin/Bootstrap/PythonBindings.py bindings/Python || true
  • python3 -m py_compile bin/Bootstrap/PythonBindings.py
  • git diff --check

I did not run a full C++ build locally because this is a generated doc-string only change across many checked-in wrapper files.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-generated doc comments for Python wrappers use ::::, e.g. Wrapper for mx::::AlwaysDestroyAttr

2 participants