Fix config file type parsing (#311)#445
Open
Bradcher wants to merge 1 commit intotrailofbits:masterfrom
Open
Conversation
configparser returns everything as strings, so --timeout=60 from a config file ends up as the string "60" and crashes subprocess.communicate with a TypeError. Added a helper that walks the argparse actions and coerces values back to int/float/bool after the config merge.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #311.
configparser returns every INI value as a string, so arguments declared
with type=int, type=float, or action="store_true" silently ended up as
strings and crashed subprocess.communicate(timeout=self.timeout) with
a TypeError.
Added a small helper that walks parser._actions after the config merge
and coerces string values back to their declared types. Invalid values
raise AnalysisBackendError.
Tests in tests/test_config_types.py exercise the helper directly.