Conversation
Contributor
stonevyt
commented
Dec 21, 2020
stonevyt
commented
- Add subbadge icon to stacked badge
- Fix bug with modifier
justasm
approved these changes
Dec 21, 2020
justasm
requested changes
Jan 4, 2021
Comment on lines
+29
to
+34
| * Badge does not work with LazyColumn and LazyColumnFor, because parent ConstraintLayout of badge | ||
| * has parameter preferredWidth(IntrinsicSize.Min). Without this parameter it is not possible to | ||
| * to set custom width to badge. | ||
| * | ||
| * One of the options is to use same modifier for ConstraintLayout and child layout | ||
| * (Surface or other) but then subbadgeIcon flies away from badge. |
Member
There was a problem hiding this comment.
As discussed with @stonevyt , this is a blocker, will need to investigate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.