Merged
Conversation
darkweaver87
force-pushed
the
fix/docs-pyyaml
branch
4 times, most recently
from
99f9b5f to
0ab378b
Compare
darkweaver87
force-pushed
the
fix/docs-pyyaml
branch
from
1438bcf to
9755b20
Compare
|
|
darkweaver87
force-pushed
the
fix/docs-pyyaml
branch
from
9755b20 to
647f981
Compare
darkweaver87
force-pushed
the
fix/docs-pyyaml
branch
from
647f981 to
ea7bc3a
Compare
mloiseleur
reviewed
Mar 17, 2026
Member
mloiseleur
left a comment
mloiseleur
left a comment
There was a problem hiding this comment.
I see the CI update but not the fix on failed dep. Is this expected ?
Collaborator
Author
|
@mloiseleur yes, the failure is on master see #874 |
mloiseleur
approved these changes
Mar 23, 2026
Fixes cython_sources AttributeError during pip install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the documentation build pipeline on
v1.4that fails withAttributeError: cython_sourcesduringpip install.Changes
Context
The structor-based publish workflow (on
master) builds documentation for every versioned branch using each branch's owndocs.Dockerfile. This creates a circular dependency:mastercan't publish becausev1.4's Dockerfile is broken, andv1.4can't be fixed withoutmasterpassing.This PR fixes the
v1.4side. The correspondingmasterfix is in #875.