feat(crewai) GenAI semconv compliance#3817
Open
max-deygin-traceloop wants to merge 2 commits intomax/tlp-1925-python-sdk-otel-semantic-conventionfrom
Open
feat(crewai) GenAI semconv compliance#3817max-deygin-traceloop wants to merge 2 commits intomax/tlp-1925-python-sdk-otel-semantic-conventionfrom
max-deygin-traceloop wants to merge 2 commits intomax/tlp-1925-python-sdk-otel-semantic-conventionfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
max-deygin-traceloop
force-pushed
the
max/tlp-1930-crewai-insturmentation
branch
from
a443c64 to
77e9177
Compare
max-deygin-traceloop
changed the title
max-deygin-traceloop
force-pushed
the
max/tlp-1925-python-sdk-otel-semantic-convention
branch
from
740ee81 to
6401889
Compare
max-deygin-traceloop
force-pushed
the
max/tlp-1930-crewai-insturmentation
branch
4 times, most recently
from
93d66c5 to
7e2c0fb
Compare
…EN_AI_ - Import GEN_AI_REQUEST_MODEL/TEMPERATURE/TOP_P/MAX_TOKENS/FREQUENCY_PENALTY/ PRESENCE_PENALTY/STOP_SEQUENCES/SEED directly from upstream gen_ai_attributes - Use SpanAttributes.GEN_AI_REQUEST_N and GEN_AI_REQUEST_MAX_COMPLETION_TOKENS (renamed from LLM_*) for the remaining non-upstream constants - Update test_semconv_attrs.py to assert upstream constants directly - Add [tool.uv.sources] for local editable semconv_ai install Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
max-deygin-traceloop
force-pushed
the
max/tlp-1930-crewai-insturmentation
branch
from
7e2c0fb to
fc8c171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refactors the Crew-AI instrumentation package to emit span attributes that comply with the
OpenTelemetry GenAI semantic conventions spec.
Summary
gen_ai.*attribute namespace, replacing legacyllm.*names)gen_ai.provider.nameto all CrewAI spans (wrap_kickoff,wrap_agent_execute_task,wrap_llm_call)tests/test_semconv_attrs.py— unit tests verifying every mapped attribute name lands correctly on emitted spans, and that no legacyllm.*attributes remain
tests/test_semconv_compliance.py— re-uses shared compliance suite fromopentelemetry-semantic-conventions-ai._testingTest plan
uv run pytest tests/test_semconv_compliance.py— all shared semconv constants passuv run pytest tests/test_semconv_attrs.py— all attribute name and legacy-absence assertions passuv run pytest tests/— full test suite passes