fix(qdrant): remove deprecated upload_records from instrumentation method lists (#3492)#3805
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughRemoved Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable the changed files summary in the walkthrough.Disable the |
…eloop#3492) QdrantClient.upload_records was removed in qdrant-client v1.13+ and is no longer present in v1.16.1. Although _instrument already guards via hasattr(), keeping stale entries in the method JSON is misleading and causes unnecessary warnings. Remove upload_records from both qdrant_client_methods.json and async_qdrant_client_methods.json. Verified: qdrant-client==1.16.1 exposes upload_points and upload_collection but not upload_records.
ca20848 to
e952441
Compare
Summary
Fixes #3492
Problem
QdrantClient.upload_recordswas removed fromqdrant-clientin v1.13 and is not present in v1.16.1+. The method was still listed in bothqdrant_client_methods.jsonandasync_qdrant_client_methods.json, causing anAttributeErrorat instrumentation time for users on newerqdrant-clientversions:Note: The
_instrumentmethod already guards against missing attributes viahasattr(), so the crash only affects older published versions of this package. However, keeping stale entries is misleading — they suggest telemetry is being captured for a method that no longer exists.Fix
Remove
upload_recordsfrom both:qdrant_client_methods.jsonasync_qdrant_client_methods.jsonVerification
Installed
qdrant-client==1.16.1and confirmed viadir(QdrantClient)thatupload_pointsandupload_collectionare present, butupload_recordsis not.Summary by CodeRabbit