ログインしている人の最終オンライン時刻が古くなっていた問題を修正 #4012
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
mehm8128
reviewed
Jul 5, 2023
Contributor
mehm8128
left a comment
mehm8128
left a comment
There was a problem hiding this comment.
オンライン中の人は今の時刻じゃなくて「オンライン」みたいな表示でいいかなーって思ってたのですがどうですか(デザインチームとなんか話したりしてましたっけ)
Contributor
Author
|
確かに「オンライン」みたいな表示でも良い気がしますね…… |
Contributor
|
なるほどです |
ras0q
previously requested changes
Nov 30, 2023
Member
ras0q
left a comment
ras0q
left a comment
There was a problem hiding this comment.
オンラインのデザイン変わったので最新にするとよさそう
last-onlineで時刻にパースしてるせいで表示バグってる
Contributor
|
これ多分デザインチームでそこそこ大きく変更を検討してるので一旦放置でいい気がしています |
Member
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #3893