Skip to content

domainへの変換でprivilegedの値が抜けていたのを修正する#643

Open
mathsuky wants to merge 1 commit into
mainfrom
fix/user-converter-privileged
Open

domainへの変換でprivilegedの値が抜けていたのを修正する#643
mathsuky wants to merge 1 commit into
mainfrom
fix/user-converter-privileged

Conversation

@mathsuky
Copy link
Copy Markdown
Contributor

@mathsuky mathsuky commented May 24, 2026

フロントで進捗部屋追加をしようとした時に権限エラーが出ていたので,軽微な修正をしました。

Summary by CodeRabbit

リリースノート

  • バグ修正
    • ユーザー権限情報の処理を改善し、権限データが正確に反映されるようになりました。

Review Change Stack

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9091924c-8351-48e1-91bc-0c60a3598d50

📥 Commits

Reviewing files that changed from the base of the PR and between c584227 and 30f4d8c.

📒 Files selected for processing (1)
  • infra/db/converter.go

📝 Walkthrough

Walkthrough

infra/db/converter.goconvUserTodomainUser 関数に、入力データベースモデルの Privilege フィールドを出力ドメインモデルの Privileged フィールドにマッピングする処理が追加されました。

Changes

User privilege field mapping

Layer / File(s) Summary
Privilege field mapping in user conversion
infra/db/converter.go
convUserTodomainUser 関数の変換ロジックに src.Privilegedst.Privileged に代入する1行が追加され、ユーザーの権限情報がドメインモデルに正しく反映されるようになりました。

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed タイトルはプルリクエストの主な変更内容(domain変換時のprivileged値の欠落を修正)を明確に要約しており、変更セット全体に関連している。
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/user-converter-privileged

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant