Skip to content

Improve tests for 360 Secure Browser #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
totpero merged 1 commit into from
Dec 4, 2024
Merged

Improve tests for 360 Secure Browser #91

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 29 additions & 7 deletions DeviceDetector.NET.Tests/DeviceDetectorTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,11 +800,12 @@ public void TestIssue88_Test1()
var dd = DeviceDetector.GetInfoFromUserAgent(userAgent);
dd.Success.Should().BeTrue();
var browserMatch = dd.Match.Client as BrowserMatchResult;
browserMatch.Should().Be("Chrome");
browserMatch.Should().Be("131.0.0.0");
browserMatch.EngineVersion.Should().Be("Blink");

browserMatch.Name.Should().Be("Chrome");
browserMatch.Version.Should().Be("131.0.0.0");
browserMatch.Engine.Should().Be("Blink");
browserMatch.EngineVersion.Should().Be("131.0.0.0");
}

/// <summary>
/// Issue #88
/// </summary>
Expand All @@ -819,9 +820,30 @@ public void TestIssue88_Test2()
var dd = DeviceDetector.GetInfoFromUserAgent(userAgent, clientHints);
dd.Success.Should().BeTrue();
var browserMatch = dd.Match.Client as BrowserMatchResult;
browserMatch.Should().Be("360 Secure Browser");
browserMatch.Should().Be("131.0.0.0");
browserMatch.EngineVersion.Should().Be("Blink");
browserMatch.Name.Should().Be("Chrome");
browserMatch.Version.Should().Be("131.0.0.0");
browserMatch.Engine.Should().Be("Blink");
browserMatch.EngineVersion.Should().Be("131.0.0.0");
}

/// <summary>
/// Issue #88
/// </summary>
[Fact]
public void TestIssue88_Test3()
{
var clientHints = ClientHints.Factory(new Dictionary<string, string>
{
["sec-ch-ua"] = "\"Chromium\";v=\"15\", \"Not.A/Brand\";v=\"8\"",
});

const string userAgent = "Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/114.0.5735.196 Safari/537.36";
var dd = DeviceDetector.GetInfoFromUserAgent(userAgent, clientHints);
dd.Success.Should().BeTrue();
var browserMatch = dd.Match.Client as BrowserMatchResult;
browserMatch.Name.Should().Be("360 Secure Browser");
browserMatch.Version.Should().Be("15");
browserMatch.Engine.Should().Be("Blink");
browserMatch.EngineVersion.Should().Be("114.0.5735.196");
}
}
Loading