Skip to content

refactor(useVisibilityEvent): optimize useVisibilityEvent hook with usePreservedCallback to prevent unnecessary effect #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wo-o29 wants to merge 2 commits into from
+6 −6
Closed

refactor(useVisibilityEvent): optimize useVisibilityEvent hook with usePreservedCallback to prevent unnecessary effect #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d48b1ab
refactor: optimize useVisibilityEvent by using usePreservedCallback f…
wo-o29 Sep 14, 2025
68255b5
docs: update description for options.immediate in useVisibilityEvent …
wo-o29 Sep 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hooks/useVisibilityEvent/ko/useVisibilityEvent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function useVisibilityEvent(
required: false,
defaultValue: 'false',
description:
'true이면, 현재 가시성 상태로 마운트 시에 즉시 콜백이 호출돼요.',
'true이면, 현재 가시성 상태로 마운트 시에 즉시 콜백이 호출돼요. <br />: 초기값은 <code>false</code>이에요.',
Comment thread
wo-o29 marked this conversation as resolved.
},
]"
/>
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useVisibilityEvent/useVisibilityEvent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ function useVisibilityEvent(
required: false,
defaultValue: 'false',
description:
'If true, the callback is invoked immediately upon mounting with the current visibility state.',
'If true, the callback is invoked immediately upon mounting with the current visibility state. <br />: The initial value is <code>false</code>.',
Comment thread
wo-o29 marked this conversation as resolved.
},
]"
/>
Expand Down
8 changes: 4 additions & 4 deletions src/hooks/useVisibilityEvent/useVisibilityEvent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
import { useCallback, useEffect } from 'react';
import { useEffect } from 'react';

import { usePreservedCallback } from '../usePreservedCallback/index.ts';

type Options = {
immediate?: boolean;
Expand Down Expand Up @@ -27,9 +29,7 @@ type Options = {
*/

export function useVisibilityEvent(callback: (visibilityState: 'visible' | 'hidden') => void, options: Options = {}) {
const handleVisibilityChange = useCallback(() => {
callback(document.visibilityState);
}, [callback]);
const handleVisibilityChange = usePreservedCallback(() => callback(document.visibilityState));
Comment thread
wo-o29 marked this conversation as resolved.

useEffect(() => {
if (options?.immediate ?? false) {
Expand Down
Loading