fix: clamp count() at 0 when offset exceeds total#2208
Open
koriyoshi2041 wants to merge 1 commit into
Open
Conversation
COUNT(*) ignores LIMIT/OFFSET, so CountQuery applies the offset in Python by subtracting it. When the offset is greater than the total row count the subtraction went negative (e.g. .offset(100).count() returned -95 for 5 rows), whereas the equivalent SQL LIMIT/OFFSET returns 0 rows. Clamp the result at 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
QuerySet.count()returns a negative number whenoffset()is larger than the total row count.COUNT(*)ignoresLIMIT/OFFSET, soCountQueryapplies the offset in Python by subtracting it (tortoise/queryset.py):When
offset > total, this goes negative. For example, with 5 rows:The fix clamps the result at
0, matching the row count the equivalent query would actually return.Motivation and Context
A count should never be negative; callers using
.offset(...).count()(e.g. for pagination "remaining" math) get a nonsensical value.How Has This Been Tested
Added
test_offset_count_beyond_totalintests/test_queryset.py: with the 30-rowIntFieldsfixture,offset(100).count()must equal0and matchlen(await ...offset(100)). It fails before the fix (-70) and passes after. Added aCHANGELOG.rstentry under 1.1.8 → Fixed.