refactor(located-error): [#1823] rename torrust-tracker-located-error to torrust-located-error#1824
Merged
josecelano merged 4 commits intoMay 22, 2026
Conversation
…ated-error Move SI-10 of EPIC torrust#1669 from drafts/ to open/ with the assigned GitHub issue number, and update frontmatter (status, github-issue, spec-path, branch, last-updated-utc).
…rror rename spec Record pre-implementation review of whether torrust-tracker-located-error should be kept and renamed or removed entirely. Recommendation: keep and rename. Awaiting reviewer confirmation in the draft PR before starting T1.
…d-error to torrust-located-error
Rename Cargo crate name in packages/located-error/Cargo.toml (T1).
No workspace-level dep existed in root Cargo.toml (T2 is N/A).
Update dep keys in 5 dependent Cargo.toml files (T3):
packages/{configuration,axum-server,http-protocol,tracker-core,tracker-client}/Cargo.toml.
Update 10 Rust source use statements from torrust_tracker_located_error::
to torrust_located_error:: across 9 files (T4).
Update prose in AGENTS.md, packages/located-error/README.md,
.github/workflows/deployment.yaml, docs/release_process.md, and
two skill files under .github/skills/ (T5).
cargo build --workspace, cargo test --workspace, and linter all all pass (T6/T7).
josecelano
changed the title
There was a problem hiding this comment.
Pull request overview
Renames the internal workspace crate torrust-tracker-located-error to the more generic torrust-located-error, updating dependency keys, Rust import paths, and related documentation/workflow references across the repository.
Changes:
- Renamed the located-error crate package name and updated all workspace
Cargo.tomldependency keys accordingly. - Updated Rust
usepaths fromtorrust_tracker_located_error::*totorrust_located_error::*. - Updated docs and release automation references to the new crate name.
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/located-error/Cargo.toml | Renames the crate to torrust-located-error. |
| packages/located-error/src/lib.rs | Updates doctest import path to the new crate identifier. |
| packages/located-error/README.md | Updates README title and docs.rs link to the new crate name. |
| packages/configuration/Cargo.toml | Renames dependency key to torrust-located-error. |
| packages/configuration/src/lib.rs | Updates Rust imports to torrust_located_error. |
| packages/axum-server/Cargo.toml | Renames dependency key to torrust-located-error. |
| packages/axum-server/src/tsl.rs | Updates Rust imports to torrust_located_error. |
| packages/http-protocol/Cargo.toml | Renames dependency key to torrust-located-error. |
| packages/http-protocol/src/v1/requests/announce.rs | Updates Rust imports to torrust_located_error. |
| packages/http-protocol/src/v1/requests/scrape.rs | Updates Rust imports to torrust_located_error. |
| packages/tracker-core/Cargo.toml | Renames dependency key to torrust-located-error. |
| packages/tracker-core/src/error.rs | Updates Rust imports (including test module) to torrust_located_error. |
| packages/tracker-core/src/databases/error.rs | Updates Rust imports to torrust_located_error. |
| packages/tracker-core/src/authentication/key/mod.rs | Updates Rust imports to torrust_located_error. |
| packages/tracker-core/src/authentication/handler.rs | Updates Rust imports to torrust_located_error. |
| packages/tracker-client/Cargo.toml | Renames dependency key to torrust-located-error. |
| packages/tracker-client/src/udp/mod.rs | Updates Rust imports to torrust_located_error. |
| Cargo.lock | Replaces the lockfile entry for the old crate name with the new one. |
| .github/workflows/deployment.yaml | Updates cargo publish target name to torrust-located-error. |
| docs/release_process.md | Updates crates.io link to torrust-located-error. |
| AGENTS.md | Updates package catalog entry for located-error crate name. |
| .github/skills/dev/rust-code-quality/handle-errors-in-code/SKILL.md | Updates dependency snippet and import path to the new crate name. |
| .github/skills/dev/git-workflow/release-new-version/SKILL.md | Updates published-crates list to the new crate name. |
| docs/issues/open/1823-1669-10-rename-torrust-tracker-located-error-to-torrust-located-error.md | Updates the spec metadata/progress to reflect the rename work. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1824 +/- ##
===========================================
- Coverage 77.70% 77.65% -0.06%
===========================================
Files 379 379
Lines 28604 28604
Branches 28604 28604
===========================================
- Hits 22227 22212 -15
+ Misses 6072 6070 -2
- Partials 305 322 +17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…rrust-located-error
Move cargo publish -p torrust-located-error to the top of the deployment
workflow so it is published before its 5 dependents (bittorrent-http-tracker-protocol,
bittorrent-tracker-client, bittorrent-tracker-core, torrust-tracker-axum-server,
torrust-tracker-configuration).
Fix handle-errors-in-code skill snippet: replace { workspace = true } with
{ version = "3.0.0-develop", path = "../located-error" } since no [workspace.dependencies]
section exists in the root Cargo.toml.
Addresses Copilot review comments on PR torrust#1824.
Member
Author
|
ACK df16e1a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #1823: rename the Cargo crate
torrust-tracker-located-error→torrust-located-error.What changed
packages/located-error/Cargo.toml:name = "torrust-located-error"Cargo.toml; all 5 dependent packages reference the crate directlyCargo.tomlfiles:packages/configuration/Cargo.tomlpackages/axum-server/Cargo.tomlpackages/http-protocol/Cargo.tomlpackages/tracker-core/Cargo.tomlpackages/tracker-client/Cargo.tomlusestatements updated (torrust_tracker_located_error::→torrust_located_error::) across 9 filesAGENTS.md,packages/located-error/README.md,.github/workflows/deployment.yaml,docs/release_process.md,.github/skills/dev/git-workflow/release-new-version/SKILL.md,.github/skills/dev/rust-code-quality/handle-errors-in-code/SKILL.mdcargo build --workspace,cargo test --workspace, andlinter allall passPre-implementation analysis
The "Pre-Implementation Review: Keep vs. Delete" section in the spec records the analysis done before committing to the rename. Recommendation was Keep + rename, which was proceeded with. If a reviewer disagrees and prefers deletion, this PR can be closed and a replacement issue opened with delete-and-migrate scope.
Spec
docs/issues/open/1823-1669-10-rename-torrust-tracker-located-error-to-torrust-located-error.md
Out of scope (deferred)
torrust-located-erroron crates.iotorrust-tracker-located-errorCloses #1823. Related to #1669.