Treat a zero timeout as immediate in queues and locks

tornado/locks.py

@@ -122,7 +122,7 @@ def wait(
         """
         waiter: Future[bool] = Future()
         self._waiters.append(waiter)
-        if timeout:
+        if timeout is not None:
 
             def on_timeout() -> None:
                 if not waiter.done():
@@ -421,7 +421,7 @@ def acquire(
             waiter.set_result(_ReleasingContextManager(self))
         else:
             self._waiters.append(waiter)
-            if timeout:
+            if timeout is not None:
 
                 def on_timeout() -> None:
                     if not waiter.done():

tornado/queues.py

@@ -55,7 +55,7 @@ class QueueFull(Exception):
 
 
 def _set_timeout(future: Future, timeout: None | float | datetime.timedelta) -> None:
-    if timeout:
+    if timeout is not None:
 
         def on_timeout() -> None:
             if not future.done():

tornado/test/queues_test.py

@@ -117,6 +117,14 @@ def test_get_timeout(self):
         q.put_nowait(0)
         self.assertEqual(0, (yield get))
 
+    @gen_test
+    def test_get_zero_timeout(self):
+        q: queues.Queue[int] = queues.Queue()
+        with self.assertRaises(TimeoutError):
+            yield q.get(timeout=timedelta(seconds=0))
+        with self.assertRaises(TimeoutError):
+            yield q.get(timeout=0)
+
     @gen_test
     def test_get_timeout_preempted(self):
         q: queues.Queue[int] = queues.Queue()