Skip to content

PM-4305 Remove photo url check for completed profiles #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkartunov merged 1 commit into from
Mar 26, 2026
Merged

PM-4305 Remove photo url check for completed profiles #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ workflows:
only:
- develop
- pm-1127_1
- pm-4203_1
- PM-4305

# Production builds are exectuted only on tagged commits to the
# master branch.
Expand Down
2 changes: 0 additions & 2 deletions sql/reports/topcoder/completed-profiles-count.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,6 @@ FROM members.member m
INNER JOIN member_skills ms ON ms.user_id = m."userId"
WHERE m.description IS NOT NULL
AND m.description <> ''
AND m."photoURL" IS NOT NULL
AND m."photoURL" <> ''
AND m."homeCountryCode" IS NOT NULL
AND ($1::text IS NULL OR COALESCE(m."homeCountryCode", m."competitionCountryCode") = $1)
AND ($3::uuid[] IS NULL OR ms.skill_ids @> $3::uuid[])
Expand Down
2 changes: 0 additions & 2 deletions sql/reports/topcoder/completed-profiles.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@ LEFT JOIN LATERAL (
) ma ON TRUE
WHERE m.description IS NOT NULL
AND m.description <> ''
AND m."photoURL" IS NOT NULL
AND m."photoURL" <> ''
AND m."homeCountryCode" IS NOT NULL
Copy link
Copy Markdown

@github-actions github-actions bot Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The removal of the photoURL check means profiles without a photo will now be considered complete. Ensure this aligns with the business requirements, as the initial comment suggests a profile photo is required for completeness.

AND ($1::text IS NULL OR COALESCE(m."homeCountryCode", m."competitionCountryCode") = $1)
AND ($5::uuid[] IS NULL OR ms.skill_ids @> $5::uuid[])
Expand Down
Loading