Skip to content

fix(PM-4203): Modified the skills filter to use AND semantics #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkartunov merged 2 commits into from
Mar 18, 2026
Merged

fix(PM-4203): Modified the skills filter to use AND semantics #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66dc60b
#time 45m modified the skills filter query
hentrymartin Mar 17, 2026
280c2fd
deploy to dev
hentrymartin Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ workflows:
only:
- develop
- pm-1127_1
- pm-4203
- pm-4203_1

# Production builds are exectuted only on tagged commits to the
# master branch.
Expand Down
2 changes: 1 addition & 1 deletion sql/reports/topcoder/completed-profiles-count.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ WHERE m.description IS NOT NULL
AND m."photoURL" <> ''
AND m."homeCountryCode" IS NOT NULL
AND ($1::text IS NULL OR COALESCE(m."homeCountryCode", m."competitionCountryCode") = $1)
AND ($3::uuid[] IS NULL OR ms.skill_ids && $3::uuid[])
AND ($3::uuid[] IS NULL OR ms.skill_ids @> $3::uuid[])
Copy link
Copy Markdown

@github-actions github-actions bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The change from && to @> alters the logic from checking for any overlap to ensuring all elements in $3 are present in ms.skill_ids. Ensure this change aligns with the intended logic for filtering by skills, as it could significantly impact the query results.

AND (
$2::boolean IS NULL
OR m."availableForGigs" = $2::boolean
Expand Down
2 changes: 1 addition & 1 deletion sql/reports/topcoder/completed-profiles.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ WHERE m.description IS NOT NULL
AND m."photoURL" <> ''
AND m."homeCountryCode" IS NOT NULL
AND ($1::text IS NULL OR COALESCE(m."homeCountryCode", m."competitionCountryCode") = $1)
AND ($5::uuid[] IS NULL OR ms.skill_ids && $5::uuid[])
AND ($5::uuid[] IS NULL OR ms.skill_ids @> $5::uuid[])
Copy link
Copy Markdown

@github-actions github-actions bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[❗❗ correctness]
The change from && to @> modifies the logic from checking for any overlap between ms.skill_ids and $5 to ensuring ms.skill_ids contains all elements of $5. Ensure this change aligns with the intended behavior of the skills filter, as it could significantly alter the query results.

AND (
$2::boolean IS NULL
OR m."availableForGigs" = $2::boolean
Expand Down
Loading