Skip to content

More optimization work to eliminate timeouts #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmgasper merged 2 commits into from
Feb 26, 2026
Merged

More optimization work to eliminate timeouts #55

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
057ac13
More optimization
jmgasper Feb 25, 2026
c3cef7f
Further join optimization so that it completes large queries within t…
jmgasper Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
107 changes: 46 additions & 61 deletions sql/reports/challenges/registrants-history.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,20 +4,19 @@ WITH submitter_role AS (
WHERE rr."nameLower" = 'submitter'
LIMIT 1
),
filtered_challenges AS (
filtered_challenges AS MATERIALIZED (
Copy link
Copy Markdown

@github-actions github-actions bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ performance]
Consider evaluating if the MATERIALIZED keyword is necessary for the filtered_challenges CTE. While it can improve performance by caching the result, it may also increase memory usage. Ensure this trade-off is beneficial for your use case.

SELECT
c.id,
c.status,
latest_phase."actualEndDate" as "challengeCompletedDate"
FROM
challenges."Challenge" c
lp."actualEndDate" AS "challengeCompletedDate"
FROM challenges."Challenge" c
LEFT JOIN LATERAL (
SELECT cp."actualEndDate"
FROM challenges."ChallengePhase" cp
WHERE cp."challengeId" = c.id
ORDER BY cp."scheduledEndDate" DESC
LIMIT 1
) latest_phase ON true
) lp ON true
WHERE
-- filter by billing account
(
Expand Down Expand Up @@ -47,72 +46,58 @@ filtered_challenges AS (
AND (
($4::timestamptz IS NULL AND $5::timestamptz IS NULL)
OR (
latest_phase."actualEndDate" IS NOT NULL
AND ($4::timestamptz IS NULL OR latest_phase."actualEndDate" >= $4::timestamptz)
AND ($5::timestamptz IS NULL OR latest_phase."actualEndDate" <= $5::timestamptz)
lp."actualEndDate" IS NOT NULL
AND ($4::timestamptz IS NULL OR lp."actualEndDate" >= $4::timestamptz)
AND ($5::timestamptz IS NULL OR lp."actualEndDate" <= $5::timestamptz)
)
)
),
registrants AS (
registrants AS MATERIALIZED (
Copy link
Copy Markdown

@github-actions github-actions bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ performance]
The MATERIALIZED keyword is used for the registrants CTE. Verify if materializing this CTE provides a significant performance benefit, as it can increase memory usage. Consider removing it if the performance gain is negligible.

-- keep one submitter resource row per challenge/member
SELECT DISTINCT ON (fc.id, res."memberId")
fc.id as "challengeId",
fc.status as "challengeStatus",
SELECT
fc.id AS "challengeId",
fc.status AS "challengeStatus",
fc."challengeCompletedDate",
res."memberId",
res."memberHandle" as "registrantHandle"
registrant."memberId",
registrant."registrantHandle"
FROM filtered_challenges fc
JOIN submitter_role sr ON true
JOIN resources."Resource" res
ON res."challengeId" = fc.id
AND res."roleId" = sr.id
ORDER BY
fc.id,
res."memberId"
JOIN LATERAL (
SELECT
res."memberId",
MAX(res."memberHandle") AS "registrantHandle"
FROM resources."Resource" res
WHERE res."challengeId" = fc.id
AND res."roleId" = sr.id
GROUP BY res."memberId"
) registrant ON true
LIMIT 1000
),
winners AS (
-- aggregate winners only for already-selected registrants
SELECT
r."challengeId",
r."memberId",
MAX(cw.handle) as "winnerHandle"
FROM registrants r
JOIN challenges."ChallengeWinner" cw
ON cw."challengeId" = r."challengeId"
AND cw."userId"::text = r."memberId"
WHERE cw.placement = 1
GROUP BY r."challengeId", r."memberId"
),
submissions AS (
-- aggregate submissions only for already-selected registrants
SELECT
r."challengeId",
r."memberId",
MAX(sub."finalScore") as "finalScore",
BOOL_OR(sub.placement = 1) as "isWinner"
FROM registrants r
JOIN reviews.submission sub
ON sub."challengeId" = r."challengeId"
AND sub."memberId" = r."memberId"
GROUP BY r."challengeId", r."memberId"
)
SELECT
registrants."challengeId",
registrants."challengeStatus",
r."challengeId",
r."challengeStatus",
win."winnerHandle",
COALESCE(sub."isWinner", false) as "isWinner",
COALESCE(sub."isWinner", false) AS "isWinner",
CASE
WHEN registrants."challengeStatus" = 'COMPLETED'
THEN registrants."challengeCompletedDate"
WHEN r."challengeStatus" = 'COMPLETED'
THEN r."challengeCompletedDate"
ELSE null
END as "challengeCompletedDate",
registrants."registrantHandle",
ROUND(sub."finalScore", 2) as "registrantFinalScore"
FROM registrants
LEFT JOIN winners win
ON win."challengeId" = registrants."challengeId"
AND win."memberId" = registrants."memberId"
LEFT JOIN submissions sub
ON sub."challengeId" = registrants."challengeId"
AND sub."memberId" = registrants."memberId";
END AS "challengeCompletedDate",
r."registrantHandle",
sub."registrantFinalScore"
FROM registrants r
Copy link
Copy Markdown

@github-actions github-actions bot Feb 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[⚠️ performance]
The LEFT JOIN LATERAL for winnerHandle and registrantFinalScore could potentially be optimized if these subqueries are expensive. Consider evaluating their performance impact, especially if the dataset is large.

LEFT JOIN LATERAL (
SELECT MAX(cw.handle) AS "winnerHandle"
FROM challenges."ChallengeWinner" cw
WHERE cw."challengeId" = r."challengeId"
AND cw."userId"::text = r."memberId"
AND cw.placement = 1
) win ON true
LEFT JOIN LATERAL (
SELECT
BOOL_OR(s.placement = 1) AS "isWinner",
ROUND(MAX(s."finalScore"), 2) AS "registrantFinalScore"
FROM reviews.submission s
WHERE s."challengeId" = r."challengeId"
AND s."memberId" = r."memberId"
) sub ON true;
Loading