fix(PM-3454): qa feedbacks on phone number #1417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| export const ADMIN_ROLES = [UserRole.administrator] | ||
|
|
||
| export const PHONE_NUMBER_ROLES = [ |
There was a problem hiding this comment.
[maintainability]
Consider using the UserRole enum for the roles in PHONE_NUMBER_ROLES to ensure consistency and avoid potential typos or mismatches with other parts of the codebase.
Collaborator
There was a problem hiding this comment.
@hentrymartin please use the UserRole enum. We try to avoid hardcoded roles.
src/apps/profiles/src/member-profile/phones/ModifyPhonesModal/ModifyPhonesModal.tsx
Show resolved
Hide resolved
src/apps/profiles/src/member-profile/phones/ModifyPhonesModal/ModifyPhonesModal.tsx
Show resolved
Hide resolved
src/apps/profiles/src/member-profile/phones/ModifyPhonesModal/ModifyPhonesModal.tsx
Show resolved
Hide resolved
src/apps/profiles/src/member-profile/phones/ModifyPhonesModal/ModifyPhonesModal.tsx
Show resolved
Hide resolved
src/apps/profiles/src/member-profile/phones/ModifyPhonesModal/ModifyPhonesModal.tsx
Show resolved
Hide resolved
src/libs/ui/lib/components/form/form-groups/form-input/input-select/InputSelect.tsx
Show resolved
Hide resolved
src/libs/ui/lib/components/form/form-groups/form-input/input-select/InputSelect.tsx
Show resolved
Hide resolved
kkartunov
requested changes
Jan 23, 2026
|
|
||
| export const ADMIN_ROLES = [UserRole.administrator] | ||
|
|
||
| export const PHONE_NUMBER_ROLES = [ |
Collaborator
There was a problem hiding this comment.
@hentrymartin please use the UserRole enum. We try to avoid hardcoded roles.
Collaborator
Author
|
@kkartunov I've fixed the PR based on the suggestion. Can you please review it again? |
kkartunov
approved these changes
Jan 23, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related JIRA Ticket:
https://topcoder.atlassian.net/browse/PM-3454
What's in this PR?
Ticket link - https://topcoder.atlassian.net/browse/PM-3404