feat(PM-3317): Profile download API endpoint initial implementation #20
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| module.exports = { | ||
| generatePDF | ||
| } No newline at end of file |
There was a problem hiding this comment.
[💡 style]
Ensure that a newline is added at the end of the file. This is a common convention that can prevent issues with certain tools and version control systems.
| const awsConfig = { | ||
| s3: config.AMAZON.S3_API_VERSION, | ||
| // S3 Client configuration | ||
| const s3ClientConfig = { |
There was a problem hiding this comment.
[❗❗ correctness]
The s3ClientConfig object is missing the s3 key which was present in the previous awsConfig. Ensure that the S3 API version is correctly configured if required by the new SDK.
| } | ||
| // Upload to S3 | ||
| await getS3().upload(params).promise() | ||
| const upload = new Upload({ |
There was a problem hiding this comment.
[performance]
The Upload class from @aws-sdk/lib-storage is used here. Ensure that this library is compatible with the current AWS SDK version and that it handles large file uploads efficiently to avoid potential memory issues.
| callback(null, { Body: Buffer.from(photoContent) }) | ||
| }) | ||
| originalS3ClientSend = S3Client.prototype.send | ||
| S3Client.prototype.send = async function (command) { |
There was a problem hiding this comment.
[maintainability]
Overriding S3Client.prototype.send directly can lead to issues if other tests or parts of the code rely on the original behavior. Consider using a mocking library like sinon to stub this method instead, which can provide better control and restore functionality.
| callback(null) | ||
| }) | ||
| // Mock Upload class's done method for upload operations | ||
| originalUpload = Upload.prototype.done |
There was a problem hiding this comment.
[maintainability]
Overriding Upload.prototype.done directly can lead to issues if other tests or parts of the code rely on the original behavior. Consider using a mocking library like sinon to stub this method instead, which can provide better control and restore functionality.
What's in this PR?
Screenshot
OOM error