Skip to content

HOTFIX to PROD - Ignore reviewer array checks when activating Tasks #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmgasper merged 1 commit into from
Dec 3, 2025
Merged

HOTFIX to PROD - Ignore reviewer array checks when activating Tasks #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/services/ChallengeService.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2710,13 +2710,17 @@ async function updateChallenge(currentUser, challengeId, data, options = {}) {
logger.info(`${challengeId} is not a pureV5 challenge or has no winners set yet.`);
}

const finalTypeId = data.typeId || challenge.typeId;
const finalTrackId = data.trackId || challenge.trackId;
const { track, type } = await challengeHelper.validateAndGetChallengeTypeAndTrack({
typeId: challenge.typeId,
trackId: challenge.trackId,
typeId: finalTypeId,
trackId: finalTrackId,
timelineTemplateId: timelineTemplateChanged
? finalTimelineTemplateId
: challenge.timelineTemplateId,
});
const isStandardTaskType =
_.isString(_.get(type, "name")) && _.get(type, "name").trim().toLowerCase() === "task";

if (_.get(type, "isTask")) {
if (!_.isEmpty(_.get(data, "task.memberId"))) {
Expand Down Expand Up @@ -2809,6 +2813,7 @@ async function updateChallenge(currentUser, challengeId, data, options = {}) {

if (
isStatusChangingToActive &&
!isStandardTaskType &&
(challenge.status === ChallengeStatusEnum.NEW || challenge.status === ChallengeStatusEnum.DRAFT)
) {
const effectiveReviewers = Array.isArray(data.reviewers)
Expand Down
Loading