generateUrl opens browser automatically #5
Conversation
|
Thanks for the PR! A couple of things:
|
|
You're right, I always forget windows users! I'll fix it later! |
|
I've made the changes we talked about. What do you think now? 😸 |
| }); | ||
| console.log(authUrl); | ||
| if (openInBrowser) { | ||
| opn(authUrl, { wait: 0 }); |
There was a problem hiding this comment.
Since we don't wait for the page to be closed I don't think we need this wait option.
| switch (command) { | ||
| case 'generateUrl': { | ||
| await generateUrl(); | ||
| await generateUrl(argv.o); |
There was a problem hiding this comment.
To keep it consistent with the other commands, it would be better to add the non-abbreviated form as well: (argv.open || argv.o).
|
Thanks! Looks good! Besides the comments, if you add the new option to help.js we are good to go I think! |
2 participants
For lazy people (as me), copying and pasting the url is too much hassle. With this small fix, the url is automatically open in user's default browser.
Thanks for the good work!