Implement respond_to? in module Monad
#2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prompted by the statement “if this was production code, we should remember to implement `#respond_to?` as well” at http://codon.com/refactoring-ruby-with-monads. I implemented `respond_to?` by implementing `respond_to_missing?`, as recommended by http://robots.thoughtbot.com/always-define-respond-to-missing-when-overriding, so that `method` also works. This requires Ruby 1.9 and later.
Owner
|
Sorry, I had notifications turned off and didn’t notice this PR. Yours arrived first, but there’s some overlap with #5. I’d ideally like to merge an implementation that is a) correct and b) covered by tests. WDYT? |
Contributor
|
@roryokane this PR is stale... Will you add tests for your fix as @tomstuart mentioned? |
sclinede
added a commit
to sclinede/monads
that referenced
this pull request
Feb 20, 2016
Resolves tomstuart#2, as previous had no tests. See details in tomstuart#2 PR, breifly: Prompted by @tomstuart statement: "If this was production code, we should remember to implement #respond_to? as well."
sclinede
added a commit
to sclinede/monads
that referenced
this pull request
Feb 20, 2016
Resolves tomstuart#2, as previous had no tests. See details in tomstuart#2 PR, breifly: Prompted by @tomstuart statement: "If this was production code, we should remember to implement #respond_to? as well."
sclinede
added a commit
to sclinede/monads
that referenced
this pull request
Feb 20, 2016
Resolves tomstuart#2, as previous had no tests. See details in tomstuart#2 PR, breifly: Prompted by @tomstuart statement: "If this was production code, we should remember to implement #respond_to? as well."
sclinede
added a commit
to sclinede/monads
that referenced
this pull request
Feb 20, 2016
Resolves tomstuart#2, as previous had no tests. See details in tomstuart#2 PR, breifly: Prompted by @tomstuart statement: "If this was production code, we should remember to implement #respond_to? as well."
sclinede
added a commit
to sclinede/monads
that referenced
this pull request
Feb 20, 2016
Resolves tomstuart#2, as previous had no tests. See details in tomstuart#2 PR, breifly: Prompted by @tomstuart statement: "If this was production code, we should remember to implement #respond_to? as well."
sclinede
added a commit
to sclinede/monads
that referenced
this pull request
Feb 20, 2016
Resolves tomstuart#2, as previous had no tests. See details in tomstuart#2 PR, breifly: Prompted by @tomstuart statement: "If this was production code, we should remember to implement #respond_to? as well."
sclinede
added a commit
to sclinede/monads
that referenced
this pull request
Feb 20, 2016
Resolves tomstuart#2, as previous had no tests. See details in tomstuart#2 PR, breifly: Prompted by @tomstuart statement: "If this was production code, we should remember to implement #respond_to? as well."
Owner
|
This change has now been incorporated into #10, so I’m closing it. |
sclinede
added a commit
to sclinede/monads
that referenced
this pull request
Feb 20, 2016
Resolves tomstuart#2, as previous had no tests. See details in tomstuart#2 PR, breifly: Prompted by @tomstuart statement: "If this was production code, we should remember to implement #respond_to? as well."
sclinede
added a commit
to sclinede/monads
that referenced
this pull request
Feb 20, 2016
Resolves tomstuart#2, as previous had no tests. See details in tomstuart#2 PR, breifly: Prompted by @tomstuart statement: "If this was production code, we should remember to implement #respond_to? as well."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by your statement
at codon.com – Refactoring Ruby with Monads.
I implemented
#respond_to?by implementing#respond_to_missing?, as recommended by thoughtbot – Always Definerespond_to_missing?When Overridingmethod_missing, so that#methodalso works. This requires Ruby 1.9 and later.