implementing a bandpass model module#4
Open
giuspugl wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting from what has been implemented by @tomma90 , i essentially merged his module into mine . Few functionalities are still to be ported , but the bulk of the work is there.
the band models are defined as class and the user can decide which model to use :
cosineandexp)Ones the class is initialized, we can do extra actions e.g. build the sampler to generate random realizations of the band (already in place) and include high freq. for out_of band analysis .
below a comparison of two bandpasses buillt from a bandmodel from Chebyshev bandpass and a Top-hat with
expapodization.