fix: Compatibility issues with dulwich>=1.2.0#179
Merged
Conversation
tomasfarias
changed the title
tomasfarias
force-pushed
the
fix/include-dulwich-contrib-module
branch
from
8f7c39e to
33c897a
Compare
Owner
Author
|
A download is failing in the final test step, but all tests are actually passing. I'll investigate that in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dulwich>=1.2.0 dropped the contrib module which included a
ParamikoSSHVendorclass we use for SSH connections when pulling from git repos.In the future, we may include our own SSHVendor implementation (using paramiko), but for the time being require dulwich<1.2.0
Also includes a bunch of random fixes for dag tests which are always a pain to keep compatible with older versions of Airflow. MWAA and GCP are already up to at least 3.1.7, so we should be able to bump the CI versions in a follow-up PR and exclude 3.0.6.