Find All Anagrams In A String#98
Open
tom4649 wants to merge 2 commits into
Open
Conversation
nodchip
reviewed
May 19, 2026
| return [] | ||
|
|
||
| count_p = collections.Counter(p) | ||
| window = collections.Counter(s[:len_p]) |
There was a problem hiding this comment.
window は文字列であれば部分文字列のことを指すと思いますので、 Counter の変数名としては違和感を感じました。
| if len_p > len_s: | ||
| return [] | ||
|
|
||
| count_p = collections.Counter(p) |
There was a problem hiding this comment.
動詞の原形または命令形が変数名の先頭にあると、メソッド名のように感じます。 char_frequencies_in_p や char_histogram_in_p あたりはいかがでしょうか？
Owner
Author
There was a problem hiding this comment.
長すぎるのを避けるため、histogram_in_pとしました。sの方もそのようにします。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/find-all-anagrams-in-a-string/description/?envType=problem-list-v2&envId=rab78cw1