Balanced Binary Tree#95
Open
tom4649 wants to merge 2 commits into
Open
Conversation
nodchip
reviewed
May 19, 2026
| height_right = node_to_height.get(node.right) | ||
|
|
||
| if height_left is None or height_right is None: | ||
| stack.append(node) |
There was a problem hiding this comment.
最初に node を追加することで、子を調べたあとで戻ってきて調べることができるという点が、ややパズルに感じました。個人的には acceptable だと感じました。
| if node is None: | ||
| return 0 | ||
| left_h = height_or_unbalanced(node.left) | ||
| if left_h == -1: |
There was a problem hiding this comment.
-1 がマジックナンバーになってしまっているのが気になりました。 UNBALANCED 等定数に置いたほうが、理解しやすくなると思います。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/balanced-binary-tree/description/?envType=problem-list-v2&envId=rab78cw1