feat(cli): expose new cluster SDK parameters by cursor[bot] · Pull Request #378 · togethercomputer/together-py

cursor · 2026-05-20T19:09:08Z

Summary

Expose newly generated beta cluster SDK parameters in CLI create/update/list commands
Add storage lifecycle/project filters and optional storage update size handling
Add remediation list order/page-size flags and focused CLI coverage

Testing

python3 -m ruff check src/together/lib/cli/api/beta/clusters/_json_params.py src/together/lib/cli/api/beta/clusters/create.py src/together/lib/cli/api/beta/clusters/update.py src/together/lib/cli/api/beta/clusters/list.py src/together/lib/cli/api/beta/clusters/storage/create.py src/together/lib/cli/api/beta/clusters/storage/update.py src/together/lib/cli/api/beta/clusters/storage/list.py src/together/lib/cli/api/beta/clusters/remediations/list.py tests/cli/test_beta_clusters.py
python3 -m pytest tests/cli/test_beta_clusters.py

Target base branch: next (do not retarget to main).

Requested reviewers: @blainekasten, stainless-app[bot] (incoming commit author).

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

blainekasten · 2026-05-21T17:38:09Z

+    response = await show_loading_status(
+        "Loading storage volumes...",
+        config.client.beta.clusters.storage.list(project_id=project_id or omit),
+    )


@cursoragent omit these changes

Taking a look!

blainekasten · 2026-05-21T17:38:19Z

            cluster_id=cluster_id,
            mode=safe_modes or omit,
+            order_by=order_by or omit,
+            page_size=page_size if page_size is not None else omit,


@cursoragent omit these changes

Taking a look!

blainekasten · 2026-05-21T17:39:42Z


 async def list(
    after: AfterParameter = None,
+    project_id: Annotated[Optional[str], Parameter(help="Project ID to filter clusters by")] = None,


@cursoragent omit these changes

Taking a look!

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

blainekasten

@cursoragent let's not add add_ons and cluster_config to the cli yet. This needs more thought.

cursor · 2026-05-21T17:40:31Z

Done.

Removed remediation list --order-by / --page-size SDK/CLI changes
Removed matching test args/assertions
Fully reverted remaining storage/list.py formatting diff too, so that earlier “omit” comment is satisfied
Pushed commit: c2b9b411 fix(cli): omit list parameter changes

Verified:

.venv/bin/python -m ruff check ...
.venv/bin/python -m pytest tests/cli/test_beta_clusters.py

Result: 27 passed

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

blainekasten · 2026-05-21T20:39:24Z

+    shared_volume_name: SharedVolumeNameParameter = None,
+    shared_volume_region: SharedVolumeRegionParameter = None,
+    shared_volume_size_tib: SharedVolumeSizeTibParameter = None,
+    shared_volume_lifecycle_independent: SharedVolumeLifecycleIndependentParameter = None,


@cursoragent Drop these parameters since the cli has a helper flow or users can attach the volume id for a previously created one

Taking a look!

blainekasten · 2026-05-21T20:39:49Z

+    num_capacity_pool_gpus: NumCapacityPoolGpusParameter = None,
+    num_preemptible_gpus: NumPreemptibleGpusParameter = None,
+    num_reserved_gpus: NumReservedGpusParameter = None,
+    oidc_config: OidcConfigParameter = None,


@cursoragent remove this for now

Taking a look!

blainekasten · 2026-05-21T20:40:00Z

    gpu_type: GpuTypeParameter = None,
    cluster_type: ClusterTypeParameter = None,
    volume: VolumeParameter = None,
+    acceptance_tests_params: AcceptanceTestsParamsParameter = None,


@cursoragent remove this for now

Done.

Removed --shared-volume-name

Removed --shared-volume-region

Removed --shared-volume-size-tib

Removed --shared-volume-lifecycle-independent

Removed non-interactive inline shared_volume request mapping

Kept the interactive helper flow / existing --volume path

Pushed commit: 7b02fa7d fix(cli): drop inline shared volume create flags

Verified:

.venv/bin/python -m ruff check ... .venv/bin/python -m ruff format --check src/together/lib/cli/api/beta/clusters/create.py tests/cli/test_beta_clusters.py .venv/bin/pyright --pythonpath .venv/bin/python src/together/lib/cli/api/beta/clusters/_json_params.py src/together/lib/cli/api/beta/clusters/create.py src/together/lib/cli/api/beta/clusters/update.py .venv/bin/python -m pytest tests/cli/test_beta_clusters.py

Result: 26 passed

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

blainekasten · 2026-05-21T21:00:10Z

+                is_lifecycle_independent = input(
+                    "Clusters: Keep storage volume after cluster deletion? [y/N] "
+                ).strip().lower() in ("y", "yes")
+                params["shared_volume"] = _shared_volume(


@cursoragent I don't think we need this helper function. Seems like we can revert back to just instantiating a SharedVolume, right?

Done.

Removed _shared_volume

Reverted interactive storage helper flow to direct SharedVolume(...)

Removed the extra lifecycle-independent prompt tied to that helper

Pushed commit: 2aa68755 fix(cli): inline cluster shared volume creation

Verified:

.venv/bin/python -m ruff check ... .venv/bin/python -m ruff format --check src/together/lib/cli/api/beta/clusters/create.py tests/cli/test_beta_clusters.py .venv/bin/pyright --pythonpath .venv/bin/python src/together/lib/cli/api/beta/clusters/_json_params.py src/together/lib/cli/api/beta/clusters/create.py src/together/lib/cli/api/beta/clusters/update.py .venv/bin/python -m pytest tests/cli/test_beta_clusters.py

Result: 26 passed

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

cursoragent and others added 2 commits May 20, 2026 19:07

feat(cli): expose new cluster SDK parameters

9a8d14f

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

chore(cli): format cluster parameter imports

fd31e38

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

blainekasten changed the base branch from main to next May 20, 2026 19:09

blainekasten self-requested a review May 20, 2026 19:09

blainekasten marked this pull request as ready for review May 20, 2026 19:10

blainekasten reviewed May 21, 2026

View reviewed changes

fix(cli): omit storage list project filter

9f06f33

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

blainekasten reviewed May 21, 2026

View reviewed changes

cursoragent and others added 5 commits May 21, 2026 17:47

fix(cli): omit list parameter changes

c2b9b41

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

fix(cli): omit cluster list project filter

30c26d0

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

fix(cli): omit add-ons and cluster config flags

4520f26

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

fix(cli): type JSON parameter helpers

ed27806

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

fix(cli): format cluster CLI tests

e7862d0

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

blainekasten reviewed May 21, 2026

View reviewed changes

cursoragent and others added 3 commits May 21, 2026 20:41

fix(cli): drop inline shared volume create flags

7b02fa7

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

fix(cli): omit create oidc config flag

133b967

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

fix(cli): omit create acceptance tests params flag

5caa9e1

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

blainekasten reviewed May 21, 2026

View reviewed changes

fix(cli): inline cluster shared volume creation

2aa6875

Co-authored-by: Blaine Kasten <blainekasten@gmail.com>

Conversation

cursor Bot commented May 20, 2026 • edited by blainekasten Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing

Uh oh!

blainekasten May 21, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

blainekasten May 21, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

blainekasten May 21, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

blainekasten left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot commented May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blainekasten May 21, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

blainekasten May 21, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 21, 2026

Choose a reason for hiding this comment

Uh oh!

blainekasten May 21, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blainekasten May 21, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot May 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cursor Bot commented May 20, 2026 •

edited by blainekasten

Loading

cursor Bot commented May 21, 2026 •

edited

Loading

cursor Bot May 21, 2026 •

edited

Loading

cursor Bot May 21, 2026 •

edited

Loading