forked from tanishqkumar/ssd
-
Notifications
You must be signed in to change notification settings - Fork 0
(2) FA4 support (sglang-fa4 -> sglang) #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avnermay
wants to merge
13
commits into
avner/sglang
Choose a base branch
from
avner/sglang-fa4
base: avner/sglang
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
66b8b7b
FA4 support
avnermay 65301a3
Add tests and tree_mask.py so that FA4 works
avnermay aa50214
Merge branch 'avner/sglang' into avner/sglang-fa4
avnermay d1c9215
Update pyproject.toml to reflect flash-attn 4 dependency, and no more…
2463748
Fix FA4 import
avnermay d86d0fb
Add logging statement once draft process is waiting for target proces…
avnermay 1425f32
Trust remote code fix
avnermay cb51158
Add logging for draft model warmup
avnermay bfcb931
Switch all attention calls to use FA4
avnermay cce45eb
Add tests for attention fa4
avnermay 080c4a3
Upgrade transformers, pin FA4
avnermay eb5e612
DUMP_TENSORS=false fix
avnermay ff59fdf
Switch from ssh to https git dependency in pyproject.toml
avnermay File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Static Code Analysis Risk: Together python huggingface trust remote code
trust_remote_code=True downloads and executes arbitrary Python code from the model repository without sandboxing (OWASP LLM03:2025 Supply Chain). A malicious or compromised model repo can achieve RCE on every host that loads the model (CWE-94). Pin to a verified commit hash and audit remote code before use, or use models that don't require trust_remote_code.
Severity: High 🚨
Status: Open 🔴
References:
Suggested reviewers 🧐: @avnermay
More details:
🌻 View in Arnica
If you see an issue, please contact Shasheen in the #security-engineering Slack channel.
Take action by replying with an [arnica] command 💬
Actions
Use
[arnica]or[a]to interact with the Arnica bot to acknowledge or dismiss code risks.To acknowledge the finding as a valid code risk:
[arnica] ack <acknowledge additional details>To dismiss the risk with a reason:
[arnica] dismiss <fp|accept|capacity> <dismissal reason>Examples
[arnica] ack This is a valid risk and I'm looking into it[arnica] dismiss fp Dismissed - Risk Not Accurate: (i.e. False Positive)[arnica] dismiss accept Dismiss - Risk Accepted: Allow the risk to exist in the system[arnica] dismiss capacity Dismiss - No Capacity: This will need to wait for a future sprint