Skip to content

fix: TCL-6370 revert login pod to configless-only #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sagrawal-byte wants to merge 1 commit into
base: slurm-1.0-together-changes
Choose a base branch
from
Open

fix: TCL-6370 revert login pod to configless-only #34

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 1 addition & 17 deletions helm/slurm/templates/login/login-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,6 @@ spec:
labelSelector:
matchLabels:
{{- include "slurm.login.selectorLabels" . | nindent 12 }}
initContainers:
- name: fix-perms
image: "{{ .Values.login.image.repository }}:{{ .Values.login.image.tag }}"
command: ["sh", "-c", "set -e && cp /mnt/slurm/* /etc/slurm/ && chmod 644 /etc/slurm/*.conf && chmod 600 /etc/slurm/*.key && chown -R root:root /etc/slurm/"]
volumeMounts:
- name: slurm-config-projected
mountPath: /mnt/slurm
readOnly: true
- name: slurm-config
mountPath: /etc/slurm
containers:
- name: login
image: "{{ .Values.login.image.repository }}:{{ .Values.login.image.tag }}"
Expand Down Expand Up @@ -103,18 +93,12 @@ spec:
{{- end }}
{{- end }}
volumes:
- name: slurm-config
emptyDir: {}
- name: slurm-config-projected # TCL-4402: projected volume, copied by initContainer with split permissions
- name: slurm-config
projected:
defaultMode: 0600
sources:
- configMap:
name: {{ include "slurm.fullname" . }}-config
- secret:
name: {{ include "slurm.fullname" . }}-auth-slurm
- secret:
name: {{ include "slurm.fullname" . }}-auth-jwths256
Copy link
Copy Markdown

@jhu-svg jhu-svg May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qq: is this drops slurm-auth-jwths256 intentionally?
sackd's configless should fetch the JWT key too, but verify that sackd serves auth keys via configless?

{{- if .Values.login.sharedMemorySize }}
- name: dshm
emptyDir:
Expand Down
Loading