fix: add ParseTime transpilation for BigQuery to DuckDB#7673
Open
william-goode wants to merge 1 commit into
Open
fix: add ParseTime transpilation for BigQuery to DuckDB#7673william-goode wants to merge 1 commit into
william-goode wants to merge 1 commit into
Conversation
BigQuery's PARSE_TIME is parsed into exp.ParseTime but DuckDB's generator has no handler, so it falls through to function_fallback_sql and emits PARSE_TIME(...) verbatim, which DuckDB rejects. Add parsetime_sql method mirroring strtodate_sql: STRPTIME + CAST to TIME, with TRY_STRPTIME for SAFE expressions.
geooo109
reviewed
May 25, 2026
|
|
||
| def parsetime_sql(self, expression: exp.ParseTime) -> str: | ||
| formatted_time = self.format_time(expression) | ||
| function_name = "STRPTIME" if not expression.args.get("safe") else "TRY_STRPTIME" |
Collaborator
There was a problem hiding this comment.
exp.ParseTime doesn't have safe arg (because with wrong format it returns an error), so just using the STRPTIME should be fine.
geooo109
reviewed
May 25, 2026
| self.validate_all( | ||
| "SELECT CAST(STRPTIME('14:30', '%H:%M') AS TIME)", | ||
| read={"bigquery": "SELECT PARSE_TIME('%H:%M', '14:30')"}, | ||
| ) |
Collaborator
There was a problem hiding this comment.
Let's also include a test with different time formats:
bigquery input:
SELECT PARSE_TIME('%H:%M:%E6S', '15:30:00.123456')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BigQuery's
PARSE_TIMEis parsed intoexp.ParseTimebut DuckDB's generator has no handler for it. The expression falls through tofunction_fallback_sql, which emitsPARSE_TIME(...)verbatim — DuckDB rejects this since it has no such function.Fix: Add a
parsetime_sqlmethod toDuckDBGeneratorthat mirrors the existingstrtodate_sqlpattern:STRPTIME+CASTtoTIME, withTRY_STRPTIMEforSAFEexpressions.Reproduction
Test plan
validate_alltest for BigQueryPARSE_TIME→ DuckDBCAST(STRPTIME(...) AS TIME)