feat(Duckdb): Add transpilation support for ARRAY_GENERATE_RANGE function#7107
Open
fivetran-amrutabhimsenayachit wants to merge 1 commit intomainfrom
Open
feat(Duckdb): Add transpilation support for ARRAY_GENERATE_RANGE function#7107fivetran-amrutabhimsenayachit wants to merge 1 commit intomainfrom
fivetran-amrutabhimsenayachit wants to merge 1 commit intomainfrom
Conversation
2b7c93f to
f508b68
Compare
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 9189 total, 8285 passed (pass rate: 90.2%), sqlglot version: sqlglot:RD-1147618-array-generate-range: 9189 total, 8285 passed (pass rate: 90.2%), sqlglot version: Transitions: |
Comment on lines
+3131
to
+3132
| if isinstance(end, exp.Sub) and isinstance(end.expression, exp.Literal): | ||
| if end.expression.this == "1": |
Collaborator
There was a problem hiding this comment.
Why are we hard-coding checks for literals? This isn't a good signal. What are you trying to check here? Should we be using an explicit arg instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
ARRAY_GENERATE_RANGEhas a negative step value, the current transpilation produces incorrect results.For example:
Another example:
Fix:
Added pattern detection in the generateseries_sql function in. DuckDB:
Sub(stop, 1)(Snowflake's pattern)RANGE(start, stop, step)insteadRANGEhas exclusive-end semantics matching Snowflake perfectlyDuckDb after transpilation: