Fix --help/--version breaking shell integration #86
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Output help and version text to STDERR instead of STDOUT. The shell wrapper evals STDOUT on exit 0, so `try --version` was running `eval "try 1.7.1"` which launched the TUI with "1.7.1" as the search term. Similarly, `try --help` caused bash syntax errors. Alternatives considered: - Exit non-zero for help/version (implies error, misleading) - Output no-op shell command first (more complex) - Change wrapper to detect these flags (adds logic to shell function) STDERR is the common pattern for tools with shell integration (mise, direnv, etc.) and keeps the fix minimal. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where try --help and try --version were causing the shell wrapper to eval their output, resulting in unintended behavior (launching the TUI with "1.7.1" as search term or bash syntax errors).
Changes:
- Changed help text output from STDOUT to STDERR
- Changed version text output from STDERR to STDERR
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output help and version text to STDERR instead of STDOUT.
The shell wrapper evals STDOUT on exit 0, so
try --versionwasrunning
eval "try 1.7.1"which launched the TUI with "1.7.1" asthe search term. Similarly,
try --helpcaused bash syntax errors.Alternatives considered:
STDERR is the common pattern for tools with shell integration (mise,
direnv, etc.) and keeps the fix minimal.
Co-Authored-By: Claude Opus 4.5 noreply@anthropic.com