-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Add ability to package LLRT as a layer #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @tmokmss, I didn't change the package.json so thought it was best to avoid committing any updates to the package-lock.json files but it seems that won't pass the build so I've added the changes for these now 🤞 |
tmokmss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
|
Hi @tmokmss , I'm just testing all the changes above and came across a strange bug. I think I've got to the bottom of it, but wanted to get your thoughts. Where you define the Would it be better to compare the name fields: const arch = props.architecture?.name == Architecture.ARM_64.name ? 'arm64' : 'x64';I don't imagine this would happen often, but I think it is safer. Wdyt? |
|
Hey @tmokmss , I've pushed all my changes. I've reverted the |
tmokmss
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi I fixed the build issue and confirmed it works in my environment. Thanks!
|
Thanks! |
New feature to package LLRT in a layer so that it can be shared across multiple lambdas with the same binary type.
closes #19