Skip to content

Conversation

@mrhornsby
Copy link
Contributor

@mrhornsby mrhornsby commented Nov 27, 2025

New feature to package LLRT in a layer so that it can be shared across multiple lambdas with the same binary type.

closes #19

@mrhornsby mrhornsby mentioned this pull request Nov 27, 2025
@mrhornsby
Copy link
Contributor Author

Hi @tmokmss, I didn't change the package.json so thought it was best to avoid committing any updates to the package-lock.json files but it seems that won't pass the build so I've added the changes for these now 🤞

Copy link
Owner

@tmokmss tmokmss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@mrhornsby
Copy link
Contributor Author

Hi @tmokmss , I'm just testing all the changes above and came across a strange bug. I think I've got to the bottom of it, but wanted to get your thoughts.

Where you define the arch field you're comparing objects. In my current testing setup I think I've managed to get two different versions of the aws-cdk-lib because I've linked a handful of local projects.

Would it be better to compare the name fields:

const arch = props.architecture?.name == Architecture.ARM_64.name ? 'arm64' : 'x64';

I don't imagine this would happen often, but I think it is safer. Wdyt?

@mrhornsby
Copy link
Contributor Author

Hey @tmokmss , I've pushed all my changes. I've reverted the package-lock.json changes, but this seems to break the action pipeline. I'm not sure if I'm doing something wrong? Thanks again for reviewing this 🙏

Copy link
Owner

@tmokmss tmokmss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi I fixed the build issue and confirmed it works in my environment. Thanks!

@tmokmss
Copy link
Owner

tmokmss commented Dec 4, 2025

Thanks!

@tmokmss tmokmss merged commit 3c5e535 into tmokmss:main Dec 4, 2025
4 checks passed
@mrhornsby mrhornsby deleted the pr2 branch December 4, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add layer support

2 participants