Consolidating frames code #112
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate Shared Code into
shared/FolderProblem
There was significant code duplication between
export-and-sign,import, and other frames. This led to:Solution
Created a new
shared/folder containing common utilities used across all frames, following the recommendation to "unify the code between all frames by extracting shared code into reusable libraries."Changes
Updated Frames to Use Shared Code
export-and-sign:
turnkey-core.jsto import from shared and keep frame-specific code (Ed25519, verifyEnclaveSignature using @turnkey/crypto)crypto-utils.jsto re-export from shared@sharedaliasimport:
turnkey-core.jsto import from shared and keep frame-specificapplySettingslogicindex.jsandstandalone.jsto use sharedHpkeEncrypt@sharedaliasAdded CI for Shared Folder
sharedto CI matrix for tests, linting, and formatting